Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description being undefined for 3 regions #19

Open
abhilashlr opened this issue Feb 23, 2022 · 7 comments
Open

Description being undefined for 3 regions #19

abhilashlr opened this issue Feb 23, 2022 · 7 comments

Comments

@abhilashlr
Copy link
Contributor

For de-at, fr-br, and us-at the description of the country seems undefined. Preferably because the flag's value itself isn't defined on the client.en.yml file. If you suggest the text, I can help fix this and test it out.

@Ebsy
Copy link
Owner

Ebsy commented Mar 7, 2022

Hi. Thanks for the message. I created these 3 flags initially because a few close friends on my forum requested them. If I had to pick, I’d choose custom1, custom2, custom3 etc.

@mentalstring
Copy link
Contributor

@Ebsy Are you still using this plugin in production these days? Those seem very specific customisations — just wondering if there could be a way the plugin could be made more generic for more widespread use.

I hope I don't sound like I'm not thankful for your work in building this and sharing it (I am!) — just thinking how it could be made easier to be adopted by others.

@Ebsy
Copy link
Owner

Ebsy commented Mar 14, 2022

I understand. I also realize it’s not ideal to have these customizations built in by default. It was just a favor for a couple of friends.

Maybe a feature to add custom flags to the plug-in would be needed? Definitely outside of my scope though as I have zero time to work on this for the foreseeable future.

@abhilashlr
Copy link
Contributor Author

abhilashlr commented Mar 15, 2022

@Ebsy I understand you are busy and not have much time to spend on it at the moment. Would you be ok if I sent a PR that removes those 3 custom items from the list? Maybe if someone else needs something like that, we could look at customisation feature itself?

@Ebsy
Copy link
Owner

Ebsy commented Mar 15, 2022

What’s the reason for removing them?

@abhilashlr
Copy link
Contributor Author

What’s the reason for removing them?

Because it shows undefined for those 3 items.

@Ebsy
Copy link
Owner

Ebsy commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants