Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: pickup.buy(String, PickupRate) wrong params in POST request #340

Closed
kiakimov opened this issue Dec 24, 2024 · 1 comment · Fixed by #341
Closed

[Bug]: pickup.buy(String, PickupRate) wrong params in POST request #340

kiakimov opened this issue Dec 24, 2024 · 1 comment · Fixed by #341
Labels
triage Issue is being researched

Comments

@kiakimov
Copy link

Software Version

7.4.3

Language Version

jdk 17

Operating System

mac os

What happened?

  1. Obtain a pickup
  2. Call easyPostClient.pickup.buy(pickup.getId(), pickup.getPickupRates().get(0))
  3. Inside buy method PickupRate is wrapped into the "rate" json field which makes the request not correct. API complains on missed required "carrier" field .

What was expected?

To buy a pickup rate should not be wrapped into the "rate" JSON root object

https://docs.easypost.com/docs/pickups#buy-a-pickup

Sample Code

No response

Relevant logs

No response
@kiakimov kiakimov added the triage Issue is being researched label Dec 24, 2024
@Justintime50 Justintime50 mentioned this issue Jan 2, 2025
Merged
4 tasks
@Justintime50
Copy link
Member

This should work correctly in v7.4.4 and newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Issue is being researched
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: buying a pickup when providing a rate EasyPost/easypost-java
2 participants
@kiakimov @Justintime50