Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LaserShipV2 datetime parameters #336

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Add LaserShipV2 datetime parameters #336

merged 2 commits into from
Sep 23, 2022

Conversation

nwithan8
Copy link
Member

Description

Testing

  • N/A
  • Something we missed in the original PR is that DropoffMaxDatetime is a string, while PickupMaxDatetime is a DateTime object. Here, both are made DateTime objects for convenience (minor breaking change)

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team September 22, 2022 16:29
@nwithan8
Copy link
Member Author

nwithan8 commented Sep 22, 2022 •
edited
Loading

Linting fails, requires this PR: #339

@nwithan8 nwithan8 requested a review from jchen293 September 23, 2022 20:34
@nwithan8 nwithan8 merged commit cda8d1c into v4 Sep 23, 2022
@nwithan8 nwithan8 deleted the options_v4 branch September 23, 2022 20:45
@Justintime50 Justintime50 mentioned this pull request Oct 3, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50