Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setup scripts, documentation #333

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Improve setup scripts, documentation #333

merged 3 commits into from
Sep 26, 2022

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Sep 22, 2022

Description

  • Improvements to Batch scripts for new and existing Windows VMs (dependency installation via Google Drive)
  • Add nuget.config file to standardize/control our NuGet settings across machines
  • Add VM_SETUP_HELP.md for documenting/troubleshooting
  • Replace built-in dotnet format with original third-party tool dotnet-format to mitigate restore errors

Testing

  • Scripts confirmed working on Mac (where applicable) and Windows

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team September 22, 2022 00:37
@nwithan8
Copy link
Member Author

Alternatively, we can move the troubleshooting guide internally. I was just jotting down everything I came across when starting a new VM.

@nwithan8 nwithan8 marked this pull request as draft September 22, 2022 01:00
@nwithan8 nwithan8 force-pushed the setup_guide branch 2 times, most recently from f06f246 to 3e3a1d8 Compare September 22, 2022 01:04
@nwithan8 nwithan8 marked this pull request as ready for review September 22, 2022 01:28
@nwithan8 nwithan8 mentioned this pull request Sep 22, 2022
4 tasks
@Justintime50
Copy link
Member

This PR contains code from other PRs. PRs should not have diffs from another PR and instead should either wait to land in an appropriate order or rebase off something else so that the diff doesn't include the changes which are already included elsewhere.

@nwithan8
Copy link
Member Author

This PR contains code from other PRs. PRs should not have diffs from another PR and instead should either wait to land in an appropriate order or rebase off something else so that the diff doesn't include the changes which are already included elsewhere.

This PR was made first. I extracted the lint fix into other PRs in hopes of getting them merged faster.

…endency installation via Google Drive)

- Add nuget.config file to standardize/control our NuGet settings across machines
- Add VM_SETUP_HELP.md for documenting/troubleshooting
@Justintime50
Copy link
Member

Let's move what we can here internally and then let me know and I'll take another look.

@nwithan8 nwithan8 marked this pull request as draft September 26, 2022 17:04
@Justintime50 Justintime50 marked this pull request as ready for review September 26, 2022 21:35
@nwithan8 nwithan8 merged commit 9e70e1c into v4 Sep 26, 2022
@nwithan8 nwithan8 deleted the setup_guide branch September 26, 2022 21:37
@Justintime50 Justintime50 mentioned this pull request Oct 3, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants