Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of store's categories #64

Open
RayMMond opened this issue Jun 25, 2020 · 4 comments
Open

Implementation of store's categories #64

RayMMond opened this issue Jun 25, 2020 · 4 comments

Comments

@RayMMond
Copy link
Member

RayMMond commented Jun 25, 2020

How to implement categories belongs to store, like this:
image

I think the solution maybe be one of:

  1. add StoreId to Category and add related CRUD interfaces.
  2. create new type StoreCategory just like ProductCategory, it records Store-Category information instread of Product-Category information, and add related CRUD interfaces.

Personally, I perfervid second option. What do you think @gdlcf88 ?

@gdlcf88
Copy link
Member

gdlcf88 commented Jun 25, 2020

Category is designed to be managed by tenant admin users, all the stores in the same tenant have the same categories.

@RayMMond
Copy link
Member Author

I know that, but It is meaningful for each store owner to maintain its own category, just like taobao, isn't it?

@gdlcf88
Copy link
Member

gdlcf88 commented Jun 25, 2020

I know that, but It is meaningful for each store owner to maintain its own category, just like taobao, isn't it?

Products in taobao.com have both the related common categories and the custom categories, I prefer to call the latter "ProductTag". It belongs to one store so the store owners can classify their products. What do you think? @RayMMond

@RayMMond
Copy link
Member Author

I can't agree with you more, when I think about it, "ProductTag" is first thing came to my mind too.
So we should create new ProductTag class to manage it, I will work on it and create a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants