Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to parameters and variables & delete unnecessary export functions and variables in wesley1989.jl #30

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

jialinl6
Copy link
Contributor

@jialinl6 jialinl6 commented Feb 23, 2024

Fixes #15
Claims #15
Fixes #15

@jialinl6
Copy link
Contributor Author

I attempted to minimize the terms exported in wesley1989.jl, only to discover that those terms are crucial for testing purposes.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 79.09%. Comparing base (ec4659e) to head (19ef574).

Files Patch % Lines
src/dry_deposition.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files           4        4           
  Lines         177      177           
=======================================
  Hits          140      140           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctessum
Copy link
Member

ctessum commented Feb 26, 2024

I attempted to minimize the terms exported in wesley1989.jl, only to discover that those terms are crucial for testing purposes.

In the tests, for variables that aren't exported, you still use them but you just need to include the package name. For example it should be AtmosphericDeposition.ra instead of just ra.

@ctessum
Copy link
Member

ctessum commented Feb 29, 2024

This project is governed with Gov4Git. Gov4Git notices

On Thursday, 29-Feb-24 19:16:04 UTC by Gov4Git dev

Notice r5e54r

Started managing this PR as Gov4Git proposal 30 with initial approval score of 0.000000.

This project is managed by Gov4Git, a decentralized governance system for collaborative git projects.
To participate in governance, install the Gov4Git desktop app.

Notice mvvsca

This PR's approval score is now 0.000000.
The cost of review is 0.000000.
The projected bounty is now 0.000000.

Notice fnmxgs

The set of eligible issues claimed by this PR is empty.

@ctessum
Copy link
Member

ctessum commented Feb 29, 2024

This project is governed with Gov4Git. Gov4Git notices

On Thursday, 29-Feb-24 19:24:00 UTC by Gov4Git dev

Notice h2dkr4

This PR referenced #15, managed as Gov4Git concern 15.

Copy link
Member

@ctessum ctessum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctessum
Copy link
Member

ctessum commented Feb 29, 2024

This project is governed with Gov4Git. Gov4Git notices

On Thursday, 29-Feb-24 20:40:35 UTC by Gov4Git dev

Notice oluzul

This PR's approval score is now 2.000000.
The cost of review is 4.000000.
The projected bounty is now 0.000000.

Notice x3s275

The set of eligible issues claimed by this PR is empty.

Notice rkseko

This PR's approval score is now 2.000000.
The cost of review is 4.000000.
The projected bounty is now 2.000000.

Notice 6h2rih

The set of eligible issues claimed by this PR changed:

@ctessum ctessum merged commit a3c61c9 into EarthSciML:main Feb 29, 2024
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
@ctessum
Copy link
Member

ctessum commented Feb 29, 2024

This project is governed with Gov4Git. Gov4Git notices

On Thursday, 29-Feb-24 21:47:31 UTC by Gov4Git dev

Notice mer4yy

This PR, managed as Gov4Git proposal 30, has been accepted 🎉

The PR approval score was 2.000000.

No issues were claimed by this PR.

PR reviewers were rewarded as follows:

  • Reviewer @ctessum was rewarded 4.000000 credits

The cost of review of this PR was 4.000000.

PR approval tally by reviewer was:

  • Reviewer @ctessum contributed 2.000000 votes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add descriptions to parameters and variables
2 participants