Fix bugs #25
Fix bugs #25
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 80.45% 79.09% -1.37%
==========================================
Files 4 4
Lines 174 177 +3
==========================================
Hits 140 140
- Misses 34 37 +3 ☔ View full report in Codecov by Sentry. |
docs/src/dry_deposition.md
Outdated
| ```@example 1 | ||
| using AtmosphericDeposition | ||
| using ModelingToolkit |
There was a problem hiding this comment.
Need to add ModelingToolkit etc to https://github.com/EarthSciML/AtmosphericDeposition.jl/blob/main/docs/Project.toml
There was a problem hiding this comment.
Thank you for pointing that out! I will remember to update the "Project.toml" file in the "docs" file.
|
Fixes #21 |
This needs to go in the initial description of the pull request, otherwise it doesn't work. The general workflow is to create one pull request for each issue. |
src/wesley1989.jl
Outdated
| @@ -1,4 +1,4 @@ | |||
| export GasData, r_s, r_dc, r_mx, r_smx, r_lux, r_clx, r_gsx, SurfaceResistance, inf, r_i, r_lu, r_ac, r_gsS, r_gsO, r_clS, r_clO, So2Data, O3Data, No2Data, NoData, Hno3Data, H2o2Data, GasData, AldData, HchoData, OpData, PaaData, OraData, Nh3Data, PanData, Hno2Data | |||
| export GasData, r_s, r_dc, r_mx, r_smx, r_lux, r_clx, r_gsx, WesleySurfaceResistance, inf, r_i, r_lu, r_ac, r_gsS, r_gsO, r_clS, r_clO, So2Data, O3Data, No2Data, NoData, Hno3Data, H2o2Data, GasData, AldData, HchoData, OpData, PaaData, OraData, Nh3Data, PanData, Hno2Data | |||
There was a problem hiding this comment.
As one additional change, we don't need to export all these variables. We probably only want to export WesleySurfaceResistance.
Fixes #18
Fixes #17
Fixes #21