Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISC]: Handling ctrl+c input in resencmd #26

Open
asreimer opened this issue Jun 7, 2019 · 4 comments
Open

[DISC]: Handling ctrl+c input in resencmd #26

asreimer opened this issue Jun 7, 2019 · 4 comments
Assignees
Labels
discussion Let's talk about this before doing anything

Comments

@asreimer
Copy link
Contributor

asreimer commented Jun 7, 2019

What do we do with ctrl+c encountered in the resen shell? Ignore it? Exit? If a command is running, stop the currently running command?

We need to discuss this. Sparked by #25

@asreimer asreimer added the discussion Let's talk about this before doing anything label Jun 7, 2019
@asreimer
Copy link
Contributor Author

asreimer commented Jun 7, 2019

Here's one possible solution, but this doesn't help us clean things up if things are partway done when a ctrl+c is encountered.

@asreimer
Copy link
Contributor Author

asreimer commented Jun 7, 2019

We need to be careful about how we implement this depending on the OS we are running on: https://stackoverflow.com/a/52941752

@pmreyes2
Copy link
Contributor

pmreyes2 commented Jun 7, 2019

My preference would be that a keyboard interrupt event will stop the command that is running. If in the shell go to a new command prompt (or ignore it). And if you are in the middle of writing a command: don't execute it and go to a new empty command prompt.

@asreimer
Copy link
Contributor Author

Summary from today's meeting:

  1. initally implement a catch for ctrl+c so it doesn't kill resencmd.
  2. investigate how to catch ctrl+c and cleanly handle it for different commands in resen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Let's talk about this before doing anything
Projects
None yet
Development

No branches or pull requests

5 participants