You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
This bullet point is fulfilled, so this is not a blocking review criteria. However, I do have some suggestions to make EXP easier to set up.
Suggestions to improve installation instructions
The installation's dependencies are not fully stated in the INSTALL.md. I mainly refer to the requirement to have the fftw or eigen3 library pre-installed
The installation guide should ideally start with the requirements. As a new user, I am basically executing it step-by-step. However, the prerequisites (which are not automatically set-up via git submodules) eigen3, fftw are listed after the actual configuration with CMake. I would recommend to re-order this.
Suggestions to improve CMake Build System overall
Alternatively, I would recommend embracing the existing CMake build system more:
You can set up the FFTW or HDF5 (and the other) libraries via CMake's Fetch Content Module. Both libraries offer tar balls containing a CMakeList.txt. E.g.
The issue
JOSS requires
This bullet point is fulfilled, so this is not a blocking review criteria. However, I do have some suggestions to make
EXP
easier to set up.Suggestions to improve installation instructions
fftw
oreigen3
library pre-installedeigen3
,fftw
are listed after the actual configuration with CMake. I would recommend to re-order this.Suggestions to improve CMake Build System overall
Alternatively, I would recommend embracing the existing CMake build system more:
This issue is part of the JOSS review: openjournals/joss-reviews#7302
The text was updated successfully, but these errors were encountered: