Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gendisk (and gendisk2d) #3

Open
The9Cat opened this issue Mar 24, 2023 · 0 comments
Open

gendisk (and gendisk2d) #3

The9Cat opened this issue Mar 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@The9Cat
Copy link
Contributor

The9Cat commented Mar 24, 2023

  1. I changed the gendisk (initial.cc) parameters to be consistent with our new parameter choices.
  2. I added a gendisk2d (initial2.cc) which is a port of initial.cc of DiskHalo.cc to use the flat disk eof evaluator (BiorthCyl.cc) rather than the 3d eof (EmpCylSL.cc).

This is an interim solution. A better strategy would be an overall of the entire gendisk system to include:

  1. An arbitrary number of components
  2. A class hierarchy that fits all cylindrical and spherical components into a single framework to eliminate the duplication between the 2d and 3d disks.
@michael-petersen michael-petersen added the enhancement New feature or request label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michael-petersen @The9Cat