Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential Issuer Metadata display field must be an array #11

Closed
ntsbs opened this issue Feb 8, 2024 · 1 comment
Closed

Credential Issuer Metadata display field must be an array #11

ntsbs opened this issue Feb 8, 2024 · 1 comment
Assignees
Labels
EWC RFC 001 Issue Verifiable Credential

Comments

@ntsbs
Copy link
Collaborator

ntsbs commented Feb 8, 2024

The credential issuer metadata display field returned in RFC001 3.4 Discover response is a JSON object, but according to OID4VCI draft 12 Section 10.2.3 it should be

An array of objects, where each object contains display properties of a Credential Issuer for a certain language.

Current:

"display": {
    "name": "Issuer",
    "location": "Belgium",
    "locale": "en-GB",
    "cover": {
      "url": "https://server.example.com/cover.jpeg",
      "alt_text": "Issuer"
    },
    "logo": {
      "url": "https://server.example.com/logo.jpg",
      "alt_text": "Issuer"
    },
    "description": "For queries about how we are managing your data please contact the Data Protection Officer."

Expected:

"display": [
    {
      "name": "Issuer",
      "location": "Belgium",
      "locale": "en-GB",
      "cover": {
        "url": "https://server.example.com/cover.jpeg",
        "alt_text": "Issuer"
      },
      "logo": {
        "url": "https://server.example.com/logo.jpg",
        "alt_text": "Issuer"
      },
      "description": "For queries about how we are managing your data please contact the Data Protection Officer."
    }
]
@georgepadayatti georgepadayatti self-assigned this Feb 8, 2024
@georgepadayatti georgepadayatti added the EWC RFC 001 Issue Verifiable Credential label Feb 8, 2024
@lalc
Copy link
Contributor

lalc commented Feb 12, 2024

Fixed

@lalc lalc closed this as completed in 8cb183b Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EWC RFC 001 Issue Verifiable Credential
Projects
None yet
Development

No branches or pull requests

3 participants