-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variant varadic default constructed state #804
variant varadic default constructed state #804
Conversation
Review changes with SemanticDiff. |
134f8e4
into
ETLCPP:pull-request/#804-variant-varadic-default-constructed-state
Hi, |
Is there a reason why the etl must differ here? You are right, this change does look incorrect. |
Should I create a pull request? |
No need, I'm doing a simple revert, plus a couple of extra tests to check the value initialisation. |
Okay, thank you very much! Have a nice weekend. |
Hi,
It seems variant_varadic still contains valid type_id when default constructed,
initializing to
variant_npos
should resolve the issue.Regards,
Manuel