Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda-forge-feedstock-pr-action to gh actions? #1665

Closed
zklaus opened this issue Jul 14, 2022 · 7 comments
Closed

Add conda-forge-feedstock-pr-action to gh actions? #1665

zklaus opened this issue Jul 14, 2022 · 7 comments
Labels
deployment enhancement New feature or request
Milestone

Comments

@zklaus
Copy link

zklaus commented Jul 14, 2022

More of an idea rather than a fixed suggestion. There is now a github action that can automatically open a PR on the feedstock. This could potentially replace the bot opening a PR for the update. I see two main advantages: It could be quicker than waiting for the bot, and we might be able to add it for the pre-release as well. This would further cut down on the load for the release manager.

@ESMValGroup/esmvaltool-coreteam, thoughts?

@zklaus zklaus added enhancement New feature or request deployment labels Jul 14, 2022
@schlunma
Copy link
Contributor

That sounds like a good idea! I guess we would create a fork of the feedstocks from ESMValGroup in this case? And can we disable the bot opening PRs?

@zklaus
Copy link
Author

zklaus commented Jul 14, 2022

I guess we would create a fork of the feedstocks from ESMValGroup in this case?

Yes, that sounds right.

And can we disable the bot opening PRs?

Probably. In any case, I think the bot will compare version numbers, so if we are faster, it will just not spring into action.

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Jul 25, 2022

that looks good - all we have to do is to add the Make PR on conda forge feedstock step to our existing build-and-deploy-on-pypi workflow - but can we deactivate the feedstock bot? EDIT: ah just saw Klaus' reply above. We may actually leave the bot do its work if it thinks it needs to (version-wise etc)

@valeriupredoi
Copy link
Contributor

OK I completely forgot about this - guess it's the next RM that'll test it 🤣

@valeriupredoi valeriupredoi added this to the v2.8.0 milestone Oct 13, 2022
@remi-kazeroni
Copy link
Contributor

Hi @valeriupredoi, I see this issue is in the v2.8 milestone but the corresponding PR has v2.9 instead. Could you please let us know if that is still plan for v2.8 or not and put both issue and PR in the same milestone? Thanks a lot 🍺

@valeriupredoi
Copy link
Contributor

uff I'd really like to test this during a live release but never have the chance to since it's too much else to do for the actual release; I'll move this to 2.9 - we got too much to do for 2.8 already

@valeriupredoi valeriupredoi modified the milestones: v2.8.0, v2.9.0 Feb 13, 2023
@bouweandela
Copy link
Member

Closing this issue as there doesn't seem to be a lot of appetite to work on it because the time savings are fairly minimal unless we start releasing much more frequently. See #1676 (comment).

@bouweandela bouweandela closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment enhancement New feature or request
Projects
None yet
5 participants