Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with import evv4esm #4717

Open
jedwards4b opened this issue Dec 11, 2024 · 1 comment
Open

problems with import evv4esm #4717

jedwards4b opened this issue Dec 11, 2024 · 1 comment
Assignees

Comments

@jedwards4b
Copy link
Contributor

It appears that #4618 brought in the import of a non-standard python module (evv4esm) into cime. Up until this point we have been very careful not to allow import of modules that are not in the standard python distribution and this restriction has served us very well. This import is causing a number of tests in the scripts regression tests to fail for cesm which does not import this module. It took me quite a while to understand why these tests were passing in the github test container but not on my local systems. I now understand that the container imports this module through the file test-requirements.txt. But this file is not invoked in local testing.

Perhaps if there had been some collaboration or communication regarding this module with the cesm team we would be using it too but since we are not I kindly request that this be removed as a testing requirement for cesm.

@rljacob
Copy link
Member

rljacob commented Dec 11, 2024

That was a mistake and the module should not have been made part of CIME. Tests that need extra modules are supposed to run in the CIMEenv conda which can include those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants