Skip to content

PR Labels

Jump to bottom
Bill Sacks edited this page Jan 28, 2019 · 4 revisions

Pull Requests (PRs) can be given a number of different labels. All PRs should be given a status label. Other labels are optional. Some issue labels can also apply to PRs.

PR (Pull Request) tags

  • PR tag: no testing required: This PR only affects documentation or "contrib" auxiliary scripts or something that doesn't require testing or extensive review.

  • PR tag: FATES change: A change required for FATES that doesn't require a change to the API between CTSM and FATES.

  • PR tag: FATES next API: A change required for FATES that does require a change to the API between CTSM and FATES. Normally, this just goes to the fates_next_api branch.

PR (Pull Request) status

This label defines whether the PR is ready for final review, testing and merge to master.

  • PR status: work in progress: The author has submitted this for an initial review, but is still working on it.

  • PR status: later: The CTSM administrators / gatekeepers are not ready to bring in this PR yet. For example, it might change answers at a time when we don't want answer changes, or it may have some dependencies on other changes.

  • PR status: ready: This PR doesn't fall into any of the above categories, and so is ready for final review, testing and merge to master. Note that a PR can have the ready label even if reviewers have requested changes: a PR should not come to master until it has the ready label and reviewers have given their approval and all necessary tests are passing.

Clone this wiki locally