-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMORize names and units in history fields and make units UDUNITS compliant #973
Comments
Sorry I didn't see #966. This sounds nice, and would potentially be helpful over the long-term, but how much time are we looking at? From previous conversations, I thought it was just a handful of fields that @olyson needed changed for ILAMB analyses. If changing units for all output is a big time sink, are we better off only going part way on this? |
Yes, I brought the changes to the few fields in #966 to release and will do the same for master for the short term. I just want to make sure we discuss this as a longer term issue. There's hundred's of fields and many files you have to go over, so I imagine it would take a day to sort it all out. In the end we could likely add a UDUNITS compliance checker though. And units would be consistent which would be good. I've added the next flag so we'll talk about this at the next meeting. |
@dlawrenncar points out that this is tied in with a desire to change all of our field names and units to be CMIP-compliant (i.e., CMORized). That might be worth doing in conjunction with this. |
@rgknox and @glemieux this sounds like an issue in CTSM that relates to what you are doing in FATES NGEET/fates#630. |
To CMORize the units, my initial thought is that we should add an optional argument to the hist_addfld routines that gives a unit conversion from the internal variable to what is put out on the history files. Ideally this conversion would be applied just before writing the fields (no need to apply them every time step). |
super cool idea @billsacks |
The units for history fields are not UDUNITS compliant (the standard used for the CF convention). Fixing this would mean changing almost all the units. There are compliance checkers to make sure CF conventions are followed and the units can be handled. One advantage of UDUNITS compliance is that units that follow the convention can be converted and operations can be done on them.
The text was updated successfully, but these errors were encountered: