-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctsm5.3.021: Standardize time metadata (we will mark this as the release tag for ctsm5.3) #2052
base: master
Are you sure you want to change the base?
Conversation
Also renamed related dimid variable.
Also update Externals.cfg to use RTM and MOSART versions that have this same change.
Marked as blocked:dependency because, at the moment, UPDATE |
Enable prescribed crop calendars This branch enables CLM to read in externally-prescribed crop sowing dates and "cultivar" maturity requirements (growing degree-days, GDDs). This has so far only been tested with static values, and the results indicate that yield performance is worsened. However, this capability is required by the GGCMI phase 3 / ISIMIP3 Agriculture protocol. Briefly, the way this works is that an offline run is first performed with prescribed sowing dates and 364-day seasons. Instantaneous GDD accumulation is saved daily. A Python script then cross-references those daily outputs with a map of mean sowing dates to determine the mean accumulated GDDs in the growing season, saving the result as a file for use as prescribed maturity requirements.
From CTSM software engineering meeting today: This doesn't need to wait on other time-related PRs. It can come in as soon as the relevant externals are updated (and Externals.cfg here is changed to point to them). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a skim of the changes I don't see issues to comment on. The changes of ctsm5.3.018 and ctsm5.3.019 are included here, so a lot of differences will go away and it will be easier to see what's going on.
@samsrabin since you did this work, it might be good have you go over some of it with @slevis-lmwg and I. I know it was forever ago and you don't remember a lot of it, but it'll probably work fine to have all of us look at it together. So let's tentatively plan on doing that next week if possible.
At this point the python unit testing and the RXCROP tests should all work and we should make sure they do. This could be to just run ctsm_sci as mentioned just below.
If this is the tag that we are going to mark as the ctsm5.3 release tag, we should also run fates and ctsm_sci test lists. And we should make sure b4b-dev has come in by this tag. And we should make sure the WhatsNewInCtsm5.3 file is updated with the latest we have for the document that talks about it.
Stop running 0th time step For consistency with CAM. Fixes ESCOMP#925 Changes answers more than roundoff, same climate. slevis resolved conflicts: src/main/histFileMod.F90
…to standardize-time-metadata Getting my local copy of this branch in sync with the remote.
derecho testing prior to updating .gitmodules to mosart1.1.08 and rtm1_0_85 in ce7f7b2:
|
Note to self: Consider initiating further testing, but perform final testing after updating to ctsm5.3.020. |
Questions:
|
@slevis-lmwg this is a good question. If the ccs_config updates can come in quickly, I'm supportive of wrapping the external update into this tag. If this will take long, however, I'm wary of scope creep and somewhat less worried about how we're defining there minor version tags (especially since we expect a 5.4 tag to be made in the next few months). I'm also hesitant to hold up our upcoming tags, because it seemed like there are several FATES tags that are pretty critically and backed up against 5.3.021. |
Yay, I see that this was addressed here: |
Nice that we have a tag for the simple fix needed. So you should just include that here. I will say that I'm supportive of this NOT having everything clean even for this tag being a development release tag. At least in this case when running with MOM masks in stand-alone CTSM is still considered "experimental". I know it shouldn't be thought of that way, but until it's standard practice -- it's experimental. The fact that it was broken the first time we tried it -- just underscores how "experimental" it really is right now. |
And @slevis-lmwg just to be explicit on your questions:
It's not complicated, once a ccs_config PR is merged it automatically creates a tag for it. BUT what is critical here is to have done enough testing with it that it doesn't break something in CESM. In this case it was easy to approve because it was so isolated to handling a grid that wasn't working. So your testing was sufficient. @jedwards4b and @fischer-ncar are the main contributors to ccs_config from CSEG. There's a few others too though.
Not, really other than maybe doing a branch tag, but I don't think we should do that most of the time if ever. |
Also there's a possible caveat to updating to the latest ccs_config: |
It looks like those changes in ccs_config tags should be benign. But, they also haven't gone through CESM testing, so I'd treat them a little suspect. I suggest you try it with it updated, but if it causes any problems -- back that update out. |
Description of changes
Standardizes a dimension name of output variable
time_bounds
(fromhist_interval
tonbnd
), as well as attributes for that plusmcdate
,mcsec
,mdcur
, andmscur
.Specific notes
Contributors other than yourself: @billsacks, @ekluzek
CTSM Issues Fixed: Resolves #1693.
Fixes #2923
Resolves ESCOMP/MOSART#66
Resolves ESCOMP/RTM#35
Are answers expected to change (and if so in what way)? No.
Any User Interface Changes (namelist or namelist defaults changes)? No.
Testing performed
New metadata in a history file from a short test:
All
aux_clm
tests pass bit-for-bit againstctsm5.1.dev131
, except for expected failures.