-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodules to ones consistent with the cesm3_0_beta05 rpointer updates #2912
Conversation
…esn't include the RTM, MOSART or CTSM changes though
…into cesm3_0_beta05_submodules
There was some cleanup and documentation work to do in #2757 that I'm moving to here. For example:
|
iRpointer files for restart now have the simulation timestamp in the filename Add the simulation timestamp to the rpointer files. Also update submodules with this change in CMEPS and CDEPS as well as updated cime to handle it. See the notes below for an explaination about this. Add a "clm" level directory under usermods_dirs so that the component where user-mods reside is declared and to make them function the same as test-mods.
…imemgr_init, now timemgr_init is always called, remove things already done in timemgr_init and add documentation around this
From testing I see that the mosart and rtm tags bring in a previous change in answers for time. As such they can't be part of a b4b-dev tag. So I'll move their update to a future tag after the CTSM tags with all the coordinated time updates come in. |
…nto cesm3_0_beta05_submodules Conflicts: .gitmodules
@jedwards4b just tagged a fix for the SSP issues in cim36.1.58 and there's another PR to CTSM #2921 that addresses a SSP issue as well. |
… initialize2, change order of alarms to stop first then restart
…nto cesm3_0_beta05_submodules
Latest testing with ctsm_sci, aux_clm, and fates test list is showing a number of unexpected fails. So this clearly needs some adjustment. |
It looks like my list of fails was just due to disk quota on scratch space. So maybe I can make progress on this! |
aux_clm testing passes as expected other than a glitch I documented in #2930. LILACSMOKE passes, but fails baseline compare because of the missing baseline. I think I should move ctsm5.3.017 over to b4b-dev, so I'll have a clean set of baselines to compare b4b-dev to, and then I should be able to bring this in. I'll also run ctsm_sci on Derecho, and fates test list on Derecho and Izumi. |
Unexpected fail for ctsm_sci testing: ERI_Ld9.f09_g17.I2000Clm60BgcCrop.derecho_intel.clm-default (NLCOMP COMPARE_base_rest BASELINE) I'll see if the same thing shows up for ctsm5.3.017. aux_clm tests ran as expected on Derecho. Rerunning the builds on Izumi_nag now... |
The ERI test passes in ctsm5.34.017, so there's something here causing the fail. |
Resubmitting seems to have fixed the ERI test failure. So merging... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekluzek I did not have time to review your changes, but I'm approving as you requested.
Includes merge conflicts in src/cpl/lilac/lnd_comp_esmf.F90 due to PR ESCOMP#2912.
Description of changes
This updates the submodules to ones that are consistent with the cesm3_0_beta05 rpointer updates.
Specific notes
Contributors other than yourself, if any:
CESM submodule updates authors especially @jedwards4b
CTSM Issues Fixed (include github issue #):
Fixes #2899
Fixes #2920
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Any Dependencies? Yes!
Dependent on the submodules updated
Dependent on #2757
Dependent on MOSART and RTM rpointer update tags
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: Limited testing so far. Will do at least regular testing for the tag
Since this is a submodule update, possibly should also run the: fates and ctsm_sci testlists