Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in surface flux documentation? #2909

Open
seleneonowe opened this issue Dec 14, 2024 · 1 comment
Open

Possible typo in surface flux documentation? #2909

seleneonowe opened this issue Dec 14, 2024 · 1 comment
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix documentation additions or edits to user-facing documentation

Comments

@seleneonowe
Copy link
Contributor

In equation 5.134 of the CLM 5.0 docs, which gives the updated transpiration flux, defined here, on line 1179 of CLM50_Tech_Note_Fluxes.rst, the last term is the sensible heat conductance for vegetation divided by the sum of the latent heat conductances for air, vegetation and the ground.

The issue is: I was expecting all of the conductances in this term to be for latent heat, such that this term would be a normalised latent heat conductance for vegetation. That is to say, is the c_{v}^{h} written in the docs correct, or should it be replaced with c_{v}^{w} ?

It may well be correct, modelling plants is not at all my field! I just thought this equation looked odd whilst reading the docs to try to understand this component of the CLM, and reckoned it was worth opening an issue to check whether it's okay.

I had quick look in the code to see if I could find out by just checking what is actually done in the model, but not being at all familiar with the code I didn't find it. I presume it is in CanopyFluxesMod.F90 somewhere.

@wwieder wwieder added documentation additions or edits to user-facing documentation next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Dec 18, 2024
@olyson
Copy link
Contributor

olyson commented Dec 19, 2024

I think this is correct as written. I admit it looks a bit odd.

cvw
which is wtlq in the code

chw
which is wtl in the code

So these are related by
rpp
which is rpp in the code.
So, wtl = wtlq/rpp

The code that corresponds to Equation 5.134 is:

qflx_tran_veg(p) = efpot*rppdry

where

            efpot = forc_rho(c)*wtl*(wtgaq*(qsatl(p)+qsatldT(p)*dt_veg(p)) &
                 -wtgq0*qg(c)-wtaq0(p)*forc_q(c))

Note that efpot uses wtl here, so this is consistent with Equation 5.134.
efpot could also be written as

        efpot = forc_rho(c)*(wtlq/rpp)*(wtgaq*(qsatl(p)+qsatldT(p)*dt_veg(p)) &
             -wtgq0*qg(c)-wtaq0(p)*forc_q(c))

@ekluzek ekluzek added closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix documentation additions or edits to user-facing documentation
Projects
None yet
Development

No branches or pull requests

4 participants