Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landuse.timeseries files for 1979-2026 for the three VR grids (CONUS, ARCTIC, ARCTICGRIS). #2487

Closed
11 tasks done
ekluzek opened this issue Apr 25, 2024 · 12 comments · Fixed by #2490
Closed
11 tasks done
Assignees
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Apr 25, 2024

For CAM-Chem it's become recognized that we need to support landuse.timeseries files for the three VR grids we (currently) support (CONUS, ARCTIC, ARCTICGRIS). Because these are high resolution datasets supporting the whole range of 1850-2100 isn't needed. But, they would like to support a shorter time-range for it.

Since, this is beyond the historical data we have to pick a SSP for the data beyond 2015, so we'll use SSP2-4.5. This will allow CAM-Chem users to have transient PFT data that brings them into present day even for a few years into the future. Since, CMIP7 data will be coming online in a year or two and datasets will be redone, we don't need to go too far into the future, but we might as well give a few years leeway.

Definition of done:

  • Create new files from the ctsm5.2.0 tag (need both a 1979 surfdata files AND 1979-2026 landuse.timeseries)
  • Add the new files to namelist defaults
  • Add tests for these three to the ctsm_sci test list
  • Add creation of these to the gen_mksurfdata_jobscript_multi script (possibly all three together)
  • Add the creation of these to the tools/mksurfdata_esmf Makefile, so automatically built on "make all"
  • Make sure the build of the files works (and duplicates the ones from the first step when using same PE layout)
  • Rename files as detailed below
  • @ekluzek propose new compset and ctsm_sci test as detailed below
  • @slevis-lmwg add new test
  • Make sure the ctsm_sci test works with the new files in place after updating config_component.xml
  • ./rimport the files
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability tag: enh - new science labels Apr 25, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Apr 25, 2024

Part of this comes about because of the following cesm2_3_alpha17d test failures...

PEND SMS_D_Ln9_Vnuopc_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCnudged.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD
    err=ERROR : CLM build-namelist::CLMBuildNamelist::add_default() : No default value found for flanduse_timeseries.

PEND SMS_D_Ln9_Vnuopc_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FHIST.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD
     err=ERROR : CLM build-namelist::CLMBuildNamelist::add_default() : No default value found for flanduse_timeseries.

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Apr 25, 2024
@ekluzek ekluzek added this to the 2024 CESM June workshop milestone Apr 25, 2024
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Apr 25, 2024
@slevis-lmwg
Copy link
Contributor

@ekluzek I'm noting here: I think you said that these should be added to the mksurfdata_esmf Makefile, so as to be done whenever we make all.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Apr 25, 2024

@slevis-lmwg yes exactly. I've added a more detailed checklist to the top as a "definition of done". Technically all of that wouldn't need to be done now. But, it seems like it would be better to get it all done at once.

@slevis-lmwg slevis-lmwg moved this from Todo to In Progress in LMWG: Near Term Priorities Apr 25, 2024
@slevis-lmwg
Copy link
Contributor

I generated the new files' namelists using these settings:

./gen_mksurfdata_namelist --res ne0np4CONUS.ne30x8 --start-year 1979 --end-year 2026 --ssp-rcp SSP2-4.5
./gen_mksurfdata_namelist --res ne0np4.ARCTIC.ne30x4 --start-year 1979 --end-year 2026 --ssp-rcp SSP2-4.5
./gen_mksurfdata_namelist --res ne0np4.ARCTICGRIS.ne30x8 --start-year 1979 --end-year 2026 --ssp-rcp SSP2-4.5

Next I will submit jobs to generate the files.

@slevis-lmwg
Copy link
Contributor

The new files are now in /glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/ctsm5.2.0.

@ekluzek I will let you check that these seem right to you before I ./rimport them.

@wwieder
Copy link
Contributor

wwieder commented Apr 26, 2024

Thanks for doing this, @slevis-lmwg.

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Apr 26, 2024

ctsm_sci test-suite with the new tests OK

Notes:

  1. One fail that I assume is not because of my work and, besides, it was already expected to hang:
    FAIL RXCROPMATURITY_Lm61.f09_g17.IHistClm50BgcCrop.derecho_intel.clm-cropMonthOutput RUN time=6 (UNEXPECTED: expected PEND)
  2. I used a temporary workaround for the new tests to pick up the 1979 fsurdat files. A conversation has started here.

@slevis-lmwg
Copy link
Contributor

Submitted make crop-global-SSP2-4.5-ne0np4

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Apr 29, 2024

@ekluzek the sixth checkbox has raised a concerning problem:
I generated the files manually in step 1 and with the Makefile in step 6. I have now diff-ed the first two files:
diff /glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/ctsm5.2.0/surfdata_ne0np4.ARCTICGRIS.ne30x8_SSP2-4.5_1979_78pfts_c240425.asc /glade/work/slevis/git/mksurfdata_toolchain/tools/mksurfdata_esmf/surfdata_ne0np4.ARCTICGRIS.ne30x8_SSP2-4.5_1979_78pfts_c240426.asc > dif1.out
I see differences in PCT_SAND, PCT_CLAY, ORGANIC, and mapunits. Currently, my only explanation is that these ran on different numbers of tasks:

<               :Host = "derecho7" ;
<               :Number-of-tasks = 256 ;
---
>               :Host = "derecho6" ;
>               :Number-of-tasks = 1152 ;

Test: I generated the manual file again using the Makefile's PE layout and got b4b same answers as the corresponding file generated by the Makefile. This confirms that the PE layout causes the differences.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Apr 29, 2024

Hmmm. OK, a change in number of MPI tasks changes these fields. This could be an important bug, if the difference is large enough.

Compare the netcdf files with cprnc. So something like...

/glade/campaign/cesm/cesmdata/cseg/tools/cime/tools/cprnc//cprnc -m <file1> <file2>

@ekluzek
Copy link
Collaborator Author

ekluzek commented Apr 29, 2024

And is this related to #2430?

@slevis-lmwg
Copy link
Contributor

From meeting with @ekluzek:
For now, call the new files good.
Open new issue about the problem and perform testing with f09 to make easier to visualize.

@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Near Term Priorities May 6, 2024
@slevis-lmwg slevis-lmwg moved this from Stalled to In Progress in LMWG: Near Term Priorities May 7, 2024
@slevis-lmwg slevis-lmwg moved this from In Progress to Done in LMWG: Near Term Priorities May 8, 2024
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants