Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Five izumi NEON tests fail (for me) because the testnames include L10d instead of Ld10 #2043

Closed
slevis-lmwg opened this issue Jun 27, 2023 · 3 comments · Fixed by #2009
Closed

Five izumi NEON tests fail (for me) because the testnames include L10d instead of Ld10 #2043

slevis-lmwg opened this issue Jun 27, 2023 · 3 comments · Fixed by #2009
Assignees
@slevis-lmwg
Labels
testing additions or changes to tests

Comments

@slevis-lmwg
Copy link
Contributor

Brief summary of bug

See title.

General bug information

CTSM version you are using: ctsm5.1.dev129

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: Five izumi NEON tests

Details of bug

  • The tests work for me when I change L10d to Ld10, so I made the change in my testlist_clm.xml.
  • The same tests worked for @ekluzek without this change, and we were unable to understand why.
@slevis-lmwg slevis-lmwg self-assigned this Jun 27, 2023
@slevis-lmwg slevis-lmwg linked a pull request Jun 27, 2023 that will close this issue
Adding excess ground ice to CTSM #1787
Merged
@slevis-lmwg slevis-lmwg mentioned this issue Jun 27, 2023
Open
@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jun 28, 2023
@glemieux
Copy link
Collaborator

I'm seeing the same thing in testing #2009 and associated NGEET/fates#958 (comment). Should I roll the fix into #2009?

@glemieux
Copy link
Collaborator

I'm seeing the same thing in testing #2009 and associated NGEET/fates#958 (comment). Should I roll the fix into #2009?

I've got a commit for this in #2009: 74f9bd1

@slevis-lmwg
Copy link
Contributor Author

I would support rolling the fix into #2009.

@glemieux glemieux mentioned this issue Jun 30, 2023
Merged
@glemieux glemieux linked a pull request Jun 30, 2023 that will close this issue
FATES parameter file and test definition updates #2009
Merged
@billsacks billsacks added testing additions or changes to tests and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jul 6, 2023
@ekluzek ekluzek removed a link to a pull request Aug 4, 2023
Adding excess ground ice to CTSM #1787
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slevis-lmwg slevis-lmwg

Labels
testing additions or changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FATES parameter file and test definition updates glemieux/ctsm
4 participants
@billsacks @glemieux @ekluzek @slevis-lmwg