You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I started noticing this in #1643 where we noticed that there is only one FATES threaded test. In that issue we added another one for MIMICS.
I also argued that we should have more testing for FATES-SP since it's the FATES configuration with the biggest differences in CTSM code itself. It was actually a red herring that I talked about that in the MIMICS PR, but somehow my brain had conflated the two.
Since FatesSP will be a critically important configuration with FATES as the default and run with CESM configurations like F compsets with CAM or WACCMX, we'll want to have a good amount of testing for it. And as pointed out above, it actually has the biggest differences in the CTSM code with any FATES configuration. These configurations are by default run with threading as well. As such it deserves more testing.
In looking at the code, there are no OMP loops inside of FATES itself. So it's all in CTSM. There are if statements for both use_fates_sp and use_fates_planthydro inside of OMP loops inside of clmfates_interfaceMod.F90. FATES-SP also has the largest difference to CTSM code for any FATES configuration. Looking at the OMP loops another important configuration with OMP loops are transient simulations. So we should include a transient FATES threading test.
We have more threaded FATES tests now, but not very many especially in comparison to the total number of FATES tests. So we should continue to add more.
I started noticing this in #1643 where we noticed that there is only one FATES threaded test. In that issue we added another one for MIMICS.
I also argued that we should have more testing for FATES-SP since it's the FATES configuration with the biggest differences in CTSM code itself. It was actually a red herring that I talked about that in the MIMICS PR, but somehow my brain had conflated the two.
Currently the two FATES threaded tests are:
The text was updated successfully, but these errors were encountered: