Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more threading tests for FATES configurations #1736

Open
ekluzek opened this issue May 4, 2022 · 3 comments
Open

Add more threading tests for FATES configurations #1736

ekluzek opened this issue May 4, 2022 · 3 comments
Labels
enhancement new capability or improved behavior of existing capability

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented May 4, 2022

I started noticing this in #1643 where we noticed that there is only one FATES threaded test. In that issue we added another one for MIMICS.

I also argued that we should have more testing for FATES-SP since it's the FATES configuration with the biggest differences in CTSM code itself. It was actually a red herring that I talked about that in the MIMICS PR, but somehow my brain had conflated the two.

Currently the two FATES threaded tests are:

  <test name="ERP_P144x2_Ld30" grid="f45_f45_mg37" compset="I2000Clm50FatesRs" testmods="clm/mimicsFatesColdDef">
  <test name="ERP_D_P32x2_Ld3" grid="f19_g17" compset="I2000Clm50FatesCru" testmods="clm/FatesColdDef">
@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label May 4, 2022
@ekluzek
Copy link
Collaborator Author

ekluzek commented May 4, 2022

The two FatesSP tests are:

  <test name="SMS_Ld30" grid="f45_f45_mg37" compset="I2000Clm50FatesCruRsGs" testmods="clm/FatesColdDefReducedComplexSatPhen">
  <test name="ERS_Ld30" grid="f45_f45_mg37" compset="I2000Clm50FatesCruRsGs" testmods="clm/FatesColdDefReducedComplexSatPhen">

Since FatesSP will be a critically important configuration with FATES as the default and run with CESM configurations like F compsets with CAM or WACCMX, we'll want to have a good amount of testing for it. And as pointed out above, it actually has the biggest differences in the CTSM code with any FATES configuration. These configurations are by default run with threading as well. As such it deserves more testing.

@ekluzek
Copy link
Collaborator Author

ekluzek commented May 6, 2022

In looking at the code, there are no OMP loops inside of FATES itself. So it's all in CTSM. There are if statements for both use_fates_sp and use_fates_planthydro inside of OMP loops inside of clmfates_interfaceMod.F90. FATES-SP also has the largest difference to CTSM code for any FATES configuration. Looking at the OMP loops another important configuration with OMP loops are transient simulations. So we should include a transient FATES threading test.

@ekluzek
Copy link
Collaborator Author

ekluzek commented May 12, 2023

We have more threaded FATES tests now, but not very many especially in comparison to the total number of FATES tests. So we should continue to add more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

No branches or pull requests

1 participant