Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change HASLAKE to PCT_LAKE_MAX #1582

Closed
billsacks opened this issue Dec 22, 2021 · 3 comments
Closed

Change HASLAKE to PCT_LAKE_MAX #1582

billsacks opened this issue Dec 22, 2021 · 3 comments
Assignees
@billsacks
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Milestone
ctsm5.2.0

Comments

@billsacks
Copy link
Member

To work with the upcoming changes in #1579 we need to change the HASLAKE variable (read from the landuse timeseries file) to PCT_LAKE_MAX. The check for if (haslake(gi)) will need to be changed to if (pct_lake_max(gi) > 0._r8).

Currently no out-of-the-box datasets have this variable on them, but the dataset used in the smallville_dynlakes_monthly testmod does, and that will need to be changed.

This change should be made before #1579 comes to master, which is intended to happen with the ctsm5.2.mksurfdata branch.
@billsacks billsacks added enhancement new capability or improved behavior of existing capability tag: simple bfb labels Dec 22, 2021
@billsacks billsacks self-assigned this Dec 22, 2021
@billsacks billsacks added the priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations label Dec 22, 2021
@ekluzek ekluzek added this to the ctsm5.2.0 milestone Apr 27, 2022
@slevis-lmwg
Copy link
Contributor

I hope it's ok if I resolve this in #1732
I'm getting every last new dataset working and then will merge #1732 to the ctsm5.2.mksurfdata branch.

@billsacks
Copy link
Member Author

That would be great, @slevisconsulting - thank you!

@slevis-lmwg
Copy link
Contributor

I merged #1732 so I'm closing this issue.

@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
@ekluzek ekluzek moved this to Done in CTSM: High priority Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Projects
No open projects
CTSM: High priority
Status: Done
Updated datasets for CTSM5.2 (ctsm5.2.mksurfdata branch and tags)
Status: Done
Milestone
ctsm5.2.0
Development

No branches or pull requests
4 participants
@billsacks @samsrabin @ekluzek @slevis-lmwg