Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HR fluxes don't include CWD #1361

Closed
wwieder opened this issue Apr 29, 2021 · 1 comment · Fixed by #1400
Closed

HR fluxes don't include CWD #1361

wwieder opened this issue Apr 29, 2021 · 1 comment · Fixed by #1400
Assignees
@wwieder @slevis-lmwg
Labels
bug something is working incorrectly enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science

Comments

@wwieder
Copy link
Contributor

wwieder commented Apr 29, 2021 •
edited
Loading

Since CLM4 coarse woody debris physically fragments into LIT2 and LIT3 pools with zero respiration fraction.
rf_cwdl2_bgc = 0.

As a result this HR flux will not be calculated if rf_cwdl2_bgc > 0.

CTSM/src/soilbiogeochem/SoilBiogeochemCarbonFluxType.F90

Line 242 in 61770ad

!-- HR fluxes (none from CWD)

Maybe not a big deal with our current parameterization, but it causes balance check errors in the PPE runs that @djk2120 is running.

@dlawrenncar and @djk2120 do you want this fixed for the PPE, or should we table it for now? Regardless, this may be something @slevisconsulting addresses in his soil BGC refactoring we're doing for the MIMICS project.
@wwieder wwieder self-assigned this Apr 29, 2021
@wwieder wwieder added tag: bug - impacts science enhancement new capability or improved behavior of existing capability labels Apr 29, 2021
@dlawrenncar dlawrenncar added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jun 7, 2021
@billsacks billsacks added priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jun 10, 2021
@billsacks
Copy link
Member

@slevisconsulting - @wwieder is going to talk with you about this.

@slevis-lmwg slevis-lmwg mentioned this issue Jun 11, 2021
Merged
@samsrabin samsrabin added bug something is working incorrectly science Enhancement to or bug impacting science labels Aug 8, 2024
@ekluzek ekluzek moved this to Done in CTSM: High priority Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wwieder wwieder

@slevis-lmwg slevis-lmwg

Labels
bug something is working incorrectly enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science
Projects
CTSM: Perturbed Parameter Ensemble (PPE) Work
Status: Done
CTSM: High priority
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include coarse woody debris (CWD) in heterotrophic respiration (HR) slevis-lmwg/ctsm
5 participants
@billsacks @wwieder @samsrabin @dlawrenncar @slevis-lmwg