Use TS 4.7 Instantiation Expressions for filterObject return type #806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
#787 updated typescript to 4.7, which includes Instantiation Expressions, allowing us to update the return type of
filterObject()
to use a pass-through generic referenceT
for discerning the expected return based on the actual return type offlattenObject
(as outlined in #699).This PR resolves #699, and signifies a MINOR version increase (per Semantic Version).
Changes:
This PR makes the following changes:
filterObject()
to useReturnType<typeof flattenObject<T>>
for indicating that allChecklist:
Before submitting this PR, I have verified that my code:
fix/
orfeature/
branch that was initially branched off fromdevelopment
.yarn lint
) and unit testing (yarn test
).yarn package
).