New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist not working #18

Open

jafri opened this issue Jul 5, 2019 · 2 comments

jafri commented Jul 5, 2019 •

edited

Loading

eosio-reference-ios-authenticator-app/Eosio/Manifest & Metadata/AppManifest.swift

Line 37 in 7a64ca0

    
           if (item.contract == contract || item.contract == "0") && (item.action == action || item.action == "0") {

I believe an empty whitelist comes in as "", not "0".

Here is chrome authenticator code for reference:
https://github.com/EOSIO/eosio-reference-chrome-extension-authenticator-app/blob/a6d77e0678aa1479f3b0116b81ed82d14eec32f1/src/utils/manifest/ManifestValidator.ts#L126

Can someone confirm this?

TaraTritt commented Jul 5, 2019

Thanks @jafri. Yes as per the Manifest Specification, wildcards are denoted by empty string ("") in the whitelist field.

Contributor

brandonfancher commented Jul 5, 2019

@jafri Good catch. Looks like this was a regression in the Reference iOS Authenticator App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment