From bbf90d9bb298742eab6c025d3942d9155b92b0c7 Mon Sep 17 00:00:00 2001 From: Zach Butler Date: Tue, 10 Sep 2019 16:43:28 -0400 Subject: [PATCH 01/18] Simplify comments --- .cicd/generate-pipeline.sh | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index d33a0e681d6..b7025ec43bc 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -1,15 +1,16 @@ #!/bin/bash set -eo pipefail +# environment . ./.cicd/helpers/general.sh export MOJAVE_ANKA_TAG_BASE=${MOJAVE_ANKA_TAG_BASE:-'clean::cicd::git-ssh::nas::brew::buildkite-agent'} export MOJAVE_ANKA_TEMPLATE_NAME=${MOJAVE_ANKA_TEMPLATE_NAME:-'10.14.4_6C_14G_40G'} -# Use files in platforms dir as source of truth for what platforms we need to generate steps for export PLATFORMS_JSON_ARRAY='[]' +# read .cicd/platforms for FILE in $(ls $CICD_DIR/platforms); do - # Ability to skip mac or linux by not even creating the json block + # skip mac or linux by not even creating the json block ( [[ $SKIP_MAC == true ]] && [[ $FILE =~ 'macos' ]] ) && continue ( [[ $SKIP_LINUX == true ]] && [[ ! $FILE =~ 'macos' ]] ) && continue - # Prevent using both platform files (only use unpinned or pinned) + # use pinned or unpinned, not both sets of platform files if [[ $PINNED == false || $UNPINNED == true ]] && [[ ! $FILE =~ 'macos' ]]; then export SKIP_CONTRACT_BUILDER=${SKIP_CONTRACT_BUILDER:-true} export SKIP_PACKAGE_BUILDER=${SKIP_PACKAGE_BUILDER:-true} @@ -48,9 +49,8 @@ for FILE in $(ls $CICD_DIR/platforms); do done oIFS="$IFS" IFS=$'' -nIFS=$IFS # Needed to fix array splitting (\n won't work) -################### -# Anka Ensure Tag # +nIFS=$IFS # fix array splitting (\n won't work) +# base-image steps echo $PLATFORMS_JSON_ARRAY | jq -cr ".[]" | while read -r PLATFORM_JSON; do if [[ $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) =~ 'macos' ]]; then cat < Date: Tue, 10 Sep 2019 16:55:00 -0400 Subject: [PATCH 02/18] Add $RUNS for loop --- .cicd/generate-pipeline.sh | 238 +++++++++++++++++++------------------ 1 file changed, 121 insertions(+), 117 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index b7025ec43bc..c1d95721168 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -5,6 +5,7 @@ set -eo pipefail export MOJAVE_ANKA_TAG_BASE=${MOJAVE_ANKA_TAG_BASE:-'clean::cicd::git-ssh::nas::brew::buildkite-agent'} export MOJAVE_ANKA_TEMPLATE_NAME=${MOJAVE_ANKA_TEMPLATE_NAME:-'10.14.4_6C_14G_40G'} export PLATFORMS_JSON_ARRAY='[]' +[[ -z "$RUNS" ]] && export RUNS='1' # read .cicd/platforms for FILE in $(ls $CICD_DIR/platforms); do # skip mac or linux by not even creating the json block @@ -120,137 +121,140 @@ EOF fi done echo " - wait"; echo "" -# parallel tests -echo $PLATFORMS_JSON_ARRAY | jq -cr ".[]" | while read -r PLATFORM_JSON; do - if [[ ! $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) =~ 'macos' ]]; then - cat < Date: Tue, 10 Sep 2019 16:57:50 -0400 Subject: [PATCH 03/18] Add wait step between test batches --- .cicd/generate-pipeline.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index c1d95721168..a373dcc3d10 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -255,6 +255,10 @@ EOF done IFS=$nIFS done + if [[ "$RUN" != "$RUNS" ]]; then + echo ' - wait' + echo '' + fi done # pipeline tail cat < Date: Tue, 10 Sep 2019 17:04:19 -0400 Subject: [PATCH 04/18] Clearer strings --- .cicd/generate-pipeline.sh | 44 ++++++++++++++++++++------------------ 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index a373dcc3d10..cbad3ffcfea 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -19,14 +19,14 @@ for FILE in $(ls $CICD_DIR/platforms); do else [[ $FILE =~ 'unpinned' ]] && continue fi - export FILE_NAME=$(echo $FILE | awk '{split($0,a,/\.(d|s)/); print a[1] }') - export PLATFORM_NAME=$(echo $FILE_NAME | cut -d- -f1 | sed 's/os/OS/g') - export PLATFORM_NAME_UPCASE=$(echo $PLATFORM_NAME | tr a-z A-Z) - export VERSION_MAJOR=$(echo $FILE_NAME | cut -d- -f2 | cut -d. -f1) - [[ $(echo $FILE_NAME | cut -d- -f2) =~ '.' ]] && export VERSION_MINOR="_$(echo $FILE_NAME | cut -d- -f2 | cut -d. -f2)" || export VERSION_MINOR='' - export VERSION_FULL=$(echo $FILE_NAME | cut -d- -f2) + export FILE_NAME="$(echo $FILE | awk '{split($0,a,/\.(d|s)/); print a[1] }')" + export PLATFORM_NAME="$(echo $FILE_NAME | cut -d- -f1 | sed 's/os/OS/g')" + export PLATFORM_NAME_UPCASE="$(echo $PLATFORM_NAME | tr a-z A-Z)" + export VERSION_MAJOR="$(echo $FILE_NAME | cut -d- -f2 | cut -d. -f1)" + [[ "$(echo $FILE_NAME | cut -d- -f2)" =~ '.' ]] && export VERSION_MINOR="_$(echo $FILE_NAME | cut -d- -f2 | cut -d. -f2)" || export VERSION_MINOR='' + export VERSION_FULL="$(echo $FILE_NAME | cut -d- -f2)" OLDIFS=$IFS - IFS="_" + IFS='_' set $PLATFORM_NAME IFS=$OLDIFS export PLATFORM_NAME_FULL="$(capitalize $1)$( [[ ! -z $2 ]] && echo "_$(capitalize $2)" || true ) $VERSION_FULL" @@ -52,8 +52,8 @@ oIFS="$IFS" IFS=$'' nIFS=$IFS # fix array splitting (\n won't work) # base-image steps -echo $PLATFORMS_JSON_ARRAY | jq -cr ".[]" | while read -r PLATFORM_JSON; do - if [[ $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) =~ 'macos' ]]; then +echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do + if [[ "$(echo "$PLATFORM_JSON" | jq -r .FILE_NAME)" =~ 'macos' ]]; then cat < Date: Tue, 10 Sep 2019 17:05:42 -0400 Subject: [PATCH 05/18] Remove extra space --- .cicd/generate-pipeline.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index cbad3ffcfea..d1dd810ea71 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -10,7 +10,7 @@ export PLATFORMS_JSON_ARRAY='[]' for FILE in $(ls $CICD_DIR/platforms); do # skip mac or linux by not even creating the json block ( [[ $SKIP_MAC == true ]] && [[ $FILE =~ 'macos' ]] ) && continue - ( [[ $SKIP_LINUX == true ]] && [[ ! $FILE =~ 'macos' ]] ) && continue + ( [[ $SKIP_LINUX == true ]] && [[ ! $FILE =~ 'macos' ]] ) && continue # use pinned or unpinned, not both sets of platform files if [[ $PINNED == false || $UNPINNED == true ]] && [[ ! $FILE =~ 'macos' ]]; then export SKIP_CONTRACT_BUILDER=${SKIP_CONTRACT_BUILDER:-true} From 2746e121ea2cf15f0ffdd68bc272c9822d105d2d Mon Sep 17 00:00:00 2001 From: Zach Butler Date: Wed, 11 Sep 2019 14:42:57 -0400 Subject: [PATCH 06/18] Fix YAML whitespace --- .cicd/generate-pipeline.sh | 177 ++++++++++++++++++------------------- 1 file changed, 86 insertions(+), 91 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index d1dd810ea71..1b46fceec27 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -59,8 +59,7 @@ echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do command: - "git clone git@github.com:EOSIO/mac-anka-fleet.git" - "cd mac-anka-fleet && . ./ensure_tag.bash -u 12 -r 25G -a '-n'" - agents: - - "queue=mac-anka-templater-fleet" + agents: "queue=mac-anka-templater-fleet" env: REPO: ${BUILDKITE_PULL_REQUEST_REPO:-$BUILDKITE_REPO} REPO_COMMIT: $BUILDKITE_COMMIT @@ -114,8 +113,7 @@ EOF debug: true wait-network: true timeout: ${TIMEOUT:-180} - agents: - - "queue=mac-anka-large-node-fleet" + agents: "queue=mac-anka-large-node-fleet" skip: \${SKIP_$(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_UPCASE)_$(echo "$PLATFORM_JSON" | jq -r .VERSION_MAJOR)$(echo "$PLATFORM_JSON" | jq -r .VERSION_MINOR)}\${SKIP_BUILD} EOF @@ -129,39 +127,38 @@ for RUN in $(seq 1 $RUNS); do echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do if [[ ! "$(echo "$PLATFORM_JSON" | jq -r .FILE_NAME)" =~ 'macos' ]]; then cat < Date: Wed, 11 Sep 2019 14:57:21 -0400 Subject: [PATCH 07/18] Fix YAML spacing, round 2 --- .cicd/generate-pipeline.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 1b46fceec27..5957fb5cf92 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -132,8 +132,8 @@ for RUN in $(seq 1 $RUNS); do - "buildkite-agent artifact download build.tar.gz . --step '$(echo "$PLATFORM_JSON" | jq -r .ICON) $(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_FULL) - Build' && tar -xzf build.tar.gz" - "./.cicd/test.sh scripts/parallel-test.sh" env: - IMAGE_TAG: $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) - BUILDKITE_AGENT_ACCESS_TOKEN: + IMAGE_TAG: $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) + BUILDKITE_AGENT_ACCESS_TOKEN: agents: queue: "automation-eos-builder-fleet" timeout: ${TIMEOUT:-10} @@ -175,8 +175,8 @@ EOF - "buildkite-agent artifact download build.tar.gz . --step '$(echo "$PLATFORM_JSON" | jq -r .ICON) $(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_FULL) - Build' && tar -xzf build.tar.gz" - "./.cicd/test.sh scripts/serial-test.sh $TEST_NAME" env: - IMAGE_TAG: $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) - BUILDKITE_AGENT_ACCESS_TOKEN: + IMAGE_TAG: $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) + BUILDKITE_AGENT_ACCESS_TOKEN: agents: queue: "automation-eos-builder-fleet" timeout: ${TIMEOUT:-20} @@ -219,8 +219,8 @@ EOF - "buildkite-agent artifact download build.tar.gz . --step '$(echo "$PLATFORM_JSON" | jq -r .ICON) $(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_FULL) - Build' && tar -xzf build.tar.gz" - "./.cicd/test.sh scripts/long-running-test.sh $TEST_NAME" env: - IMAGE_TAG: $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) - BUILDKITE_AGENT_ACCESS_TOKEN: + IMAGE_TAG: $(echo "$PLATFORM_JSON" | jq -r .FILE_NAME) + BUILDKITE_AGENT_ACCESS_TOKEN: agents: queue: "automation-eos-builder-fleet" timeout: ${TIMEOUT:-180} From 413b047e256c43e98bf77fa575ce37e591b5c573 Mon Sep 17 00:00:00 2001 From: Zach Butler Date: Wed, 11 Sep 2019 15:17:37 -0400 Subject: [PATCH 08/18] Switch YAML to four-space to match BASH source file for consistent editor configuration --- .cicd/generate-pipeline.sh | 446 ++++++++++++++++++------------------- 1 file changed, 223 insertions(+), 223 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 5957fb5cf92..e9e56b0b49b 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -55,22 +55,22 @@ nIFS=$IFS # fix array splitting (\n won't work) echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do if [[ "$(echo "$PLATFORM_JSON" | jq -r .FILE_NAME)" =~ 'macos' ]]; then cat < Date: Wed, 11 Sep 2019 15:19:12 -0400 Subject: [PATCH 09/18] Revert "Switch YAML to four-space to match BASH source file for consistent editor configuration" This reverts commit 413b047e256c43e98bf77fa575ce37e591b5c573. --- .cicd/generate-pipeline.sh | 446 ++++++++++++++++++------------------- 1 file changed, 223 insertions(+), 223 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index e9e56b0b49b..5957fb5cf92 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -55,22 +55,22 @@ nIFS=$IFS # fix array splitting (\n won't work) echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do if [[ "$(echo "$PLATFORM_JSON" | jq -r .FILE_NAME)" =~ 'macos' ]]; then cat < Date: Wed, 11 Sep 2019 15:35:41 -0400 Subject: [PATCH 10/18] Fix misaligned cat --- .cicd/generate-pipeline.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 5957fb5cf92..4d842f79ad2 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -54,7 +54,7 @@ nIFS=$IFS # fix array splitting (\n won't work) # base-image steps echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do if [[ "$(echo "$PLATFORM_JSON" | jq -r .FILE_NAME)" =~ 'macos' ]]; then - cat < Date: Wed, 11 Sep 2019 15:37:45 -0400 Subject: [PATCH 11/18] Put wait step at top of YAML --- .cicd/generate-pipeline.sh | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 4d842f79ad2..8ff6e44e47e 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -51,6 +51,9 @@ done oIFS="$IFS" IFS=$'' nIFS=$IFS # fix array splitting (\n won't work) +# start with a wait step +echo ' - wait' +echo '' # base-image steps echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do if [[ "$(echo "$PLATFORM_JSON" | jq -r .FILE_NAME)" =~ 'macos' ]]; then @@ -72,11 +75,11 @@ echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do timeout: ${TIMEOUT:-320} skip: \${SKIP_$(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_UPCASE)_$(echo "$PLATFORM_JSON" | jq -r .VERSION_MAJOR)$(echo "$PLATFORM_JSON" | jq -r .VERSION_MINOR)}\${SKIP_ENSURE_$(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_UPCASE)_$(echo "$PLATFORM_JSON" | jq -r .VERSION_MAJOR)$(echo "$PLATFORM_JSON" | jq -r .VERSION_MINOR)} + - wait + EOF fi done -echo ' - wait' -echo '' # build steps echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do if [[ ! "$(echo "$PLATFORM_JSON" | jq -r .FILE_NAME)" =~ 'macos' ]]; then From 0044fa7002f9a0ffcb9361d985fb93555b29c73b Mon Sep 17 00:00:00 2001 From: Zach Butler Date: Wed, 11 Sep 2019 15:40:46 -0400 Subject: [PATCH 12/18] Add space after macOS serial tests in YAML --- .cicd/generate-pipeline.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 8ff6e44e47e..c74183c941b 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -205,6 +205,7 @@ EOF timeout: ${TIMEOUT:-20} agents: "queue=mac-anka-node-fleet" skip: \${SKIP_$(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_UPCASE)_$(echo "$PLATFORM_JSON" | jq -r .VERSION_MAJOR)$(echo "$PLATFORM_JSON" | jq -r .VERSION_MINOR)}\${SKIP_SERIAL_TESTS} + EOF fi done From f71ea02db6f552aa57c37f4b6aaa0f40fa2bb132 Mon Sep 17 00:00:00 2001 From: Zach Butler Date: Wed, 11 Sep 2019 15:44:28 -0400 Subject: [PATCH 13/18] Use comments to break up blocks of YAML, to help with debugging --- .cicd/generate-pipeline.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index c74183c941b..05ebc33174f 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -55,6 +55,7 @@ nIFS=$IFS # fix array splitting (\n won't work) echo ' - wait' echo '' # base-image steps +echo ' # base-images' echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do if [[ "$(echo "$PLATFORM_JSON" | jq -r .FILE_NAME)" =~ 'macos' ]]; then cat < Date: Wed, 11 Sep 2019 15:50:04 -0400 Subject: [PATCH 14/18] Print run group index in YAML comment --- .cicd/generate-pipeline.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 05ebc33174f..0a2e69fd957 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -128,6 +128,7 @@ echo ' - wait' echo '' # tests for RUN in $(seq 1 $RUNS); do + echo " # run group $RUN of $RUNS" # parallel tests echo ' # parallel tests' echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do From 59ae46f2cbee6d5971ee81cd3218ab35aa436fe3 Mon Sep 17 00:00:00 2001 From: Zach Butler Date: Wed, 11 Sep 2019 16:42:24 -0400 Subject: [PATCH 15/18] Fix IFS so FOR loop works --- .cicd/generate-pipeline.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 0a2e69fd957..38b206c80fd 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -49,7 +49,7 @@ for FILE in $(ls $CICD_DIR/platforms); do }]') done oIFS="$IFS" -IFS=$'' +IFS=$'' nIFS=$IFS # fix array splitting (\n won't work) # start with a wait step echo ' - wait' @@ -127,7 +127,9 @@ done echo ' - wait' echo '' # tests +IFS=$oIFS for RUN in $(seq 1 $RUNS); do + IFS=$'' echo " # run group $RUN of $RUNS" # parallel tests echo ' # parallel tests' @@ -262,6 +264,7 @@ EOF done IFS=$nIFS done + IFS=$oIFS if [[ "$RUN" != "$RUNS" ]]; then echo ' - wait' echo '' From 8fc6ef3fd12c13ad82b72ba2e214972b57eae910 Mon Sep 17 00:00:00 2001 From: Zach Butler Date: Wed, 11 Sep 2019 16:42:45 -0400 Subject: [PATCH 16/18] Remove extra space --- .cicd/generate-pipeline.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 38b206c80fd..32bda923ef0 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -272,7 +272,6 @@ EOF done # pipeline tail cat < Date: Thu, 12 Sep 2019 15:41:12 -0400 Subject: [PATCH 17/18] Rename RUNS variable to ROUNDS to avoid confusion when writing about multiple test-stability runs --- .cicd/generate-pipeline.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 32bda923ef0..9508cd1e1f5 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -5,7 +5,7 @@ set -eo pipefail export MOJAVE_ANKA_TAG_BASE=${MOJAVE_ANKA_TAG_BASE:-'clean::cicd::git-ssh::nas::brew::buildkite-agent'} export MOJAVE_ANKA_TEMPLATE_NAME=${MOJAVE_ANKA_TEMPLATE_NAME:-'10.14.4_6C_14G_40G'} export PLATFORMS_JSON_ARRAY='[]' -[[ -z "$RUNS" ]] && export RUNS='1' +[[ -z "$ROUNDS" ]] && export ROUNDS='1' # read .cicd/platforms for FILE in $(ls $CICD_DIR/platforms); do # skip mac or linux by not even creating the json block @@ -128,9 +128,9 @@ echo ' - wait' echo '' # tests IFS=$oIFS -for RUN in $(seq 1 $RUNS); do +for ROUND in $(seq 1 $ROUNDS); do IFS=$'' - echo " # run group $RUN of $RUNS" + echo " # round $ROUND of $ROUNDS" # parallel tests echo ' # parallel tests' echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do @@ -265,7 +265,7 @@ EOF IFS=$nIFS done IFS=$oIFS - if [[ "$RUN" != "$RUNS" ]]; then + if [[ "$ROUND" != "$ROUNDS" ]]; then echo ' - wait' echo '' fi From ce47af29fd39ba3754ac04e37a1ab56a2c041951 Mon Sep 17 00:00:00 2001 From: Zach Butler Date: Thu, 12 Sep 2019 16:51:30 -0400 Subject: [PATCH 18/18] Don't wait between base-image steps, wait after them --- .cicd/generate-pipeline.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.cicd/generate-pipeline.sh b/.cicd/generate-pipeline.sh index 9508cd1e1f5..1e11060236e 100755 --- a/.cicd/generate-pipeline.sh +++ b/.cicd/generate-pipeline.sh @@ -76,11 +76,11 @@ echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do timeout: ${TIMEOUT:-320} skip: \${SKIP_$(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_UPCASE)_$(echo "$PLATFORM_JSON" | jq -r .VERSION_MAJOR)$(echo "$PLATFORM_JSON" | jq -r .VERSION_MINOR)}\${SKIP_ENSURE_$(echo "$PLATFORM_JSON" | jq -r .PLATFORM_NAME_UPCASE)_$(echo "$PLATFORM_JSON" | jq -r .VERSION_MAJOR)$(echo "$PLATFORM_JSON" | jq -r .VERSION_MINOR)} - - wait - EOF fi done +echo ' - wait' +echo '' # build steps echo ' # builds' echo $PLATFORMS_JSON_ARRAY | jq -cr '.[]' | while read -r PLATFORM_JSON; do