Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Federator] Geographic constraints not working as expected #148

Open
ogalanis opened this issue Sep 21, 2023 · 6 comments
Open

[Federator] Geographic constraints not working as expected #148

ogalanis opened this issue Sep 21, 2023 · 6 comments
Assignees
Labels
bug Something isn't working Federator StationWS

Comments

@ogalanis
Copy link

The response to the station service includes stations that should have been excluded by the geographic constraints. E.g. the following query:

http://eida-federator.ethz.ch/fdsnws/station/1/query?starttime=2022-06-01T00%3A00%3A00&endtime=2022-06-10T00%3A00%3A00&minlatitude=38&maxlatitude=39&minlongitude=21&maxlongitude=22&format=text&level=channel&nodata=404

... also returns stations such as:
KO|KAMT||HHZ|39.3692|33.7124|1120.0|...
BW|PART||HHZ|47.497238|11.11313|760.0|...
2D|EF02|00|HHZ|50.36329|7.25004|247.0|...
...
RA|MALA|00|HNE|14.595300|-60.995660|21.0|...

If it helps with the debugging, the last station has the exact same station code with a station in the specified area (but with a different network code), but in most cases it seems to be random.

This happens both in the browser and ObsPy.

I noticed this yesterday (2023-09-20) and today.

@megies
Copy link

megies commented Sep 21, 2023

This happens both in the browser and ObsPy

That's expected, obspy doesn't do any filtering itself besides putting the filter constraints in the requested URL or POST payload

@javiquinte
Copy link
Collaborator

Hi. The same query (even simplified) sent to the Routing Service works perfectly.

http://orfeus-eu.org/eidaws/routing/1/query?minlatitude=38&maxlatitude=39&minlongitude=21&maxlongitude=22&format=post

The four stations mentioned in the first post appear, but with different network codes. And the lat/lon properties are OK and respect the query filters.
With Obspy is also perfect, so no problem there.

Same query sent to the Station-WS of the corresponding nodes look OK also.

@ogalanis ogalanis changed the title Geographic constraints not working as expected [Federator] Geographic constraints not working as expected Sep 22, 2023
@ogalanis
Copy link
Author

Yes, this has to be a Federator issue, not a routing or an individual node issue.

@kaestli
Copy link

kaestli commented Sep 22, 2023

I acknowledge this as a federator bug (error in the internal routing, most probably due to insufficient tracking of the network in case a station code used for stations in multiple networks, with different coordinates). Investigations ongoing.

@javiquinte javiquinte added bug Something isn't working StationWS Federator labels Oct 27, 2023
@kaestli
Copy link

kaestli commented Nov 24, 2023

This is a serious issue in the the federator's routing behaviour: it assumes uniqueness of station names.

As a consequence, queries for stations with its stationcodes available in multiple networks may return data of the station of the wrong network, if the selection is based on station properties only (lat, lon, start- and end time). This affects mostly temporary stations with non-speaking names (A01, A02 ...)
The software issue is tracked here: EIDA/eidaws#34 ; fixing it will take some time.

@kaestli
Copy link

kaestli commented Mar 18, 2024

just to tell you that we are finally working on this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Federator StationWS
Projects
None yet
Development

No branches or pull requests

4 participants