Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make disable on site more prominent #2787

Merged
merged 19 commits into from
Jul 27, 2021

Conversation

ablanathtanalba
Copy link
Contributor

@ablanathtanalba ablanathtanalba commented Jul 22, 2021

Related to #2781, #2021. Supersedes #2660.

This makes some more cosmetic changes to the popup to make the disable and enable buttons more prominent.

  • adds a colored "power" icon to make it more visually clear what the button does
  • simplifies the language on the button by removing "Privacy Badger" from the message (it's obvious that the control is for Privacy Badger)
  • changes the disable and enable buttons to be stacked at 100% width with the other two buttons below sharing a single row.

Screen Shot 2021-07-21 at 5 28 20 PM

@ablanathtanalba

This comment has been minimized.

@ablanathtanalba
Copy link
Contributor Author

ablanathtanalba commented Jul 23, 2021

Thanks for these tweaks!

I'm definitely in favor of simplifying the report button message as well. That's a keeper.

I'm on the fence about the rounded corners for the buttons. On the one hand, it does kinda fall in line with how many other web things style their buttons, so it appeals to that sense of familiarity with people. On the other hand, the curve radius on the button is just different enough from the highlighted blocked resources outlines that it's noticeable and kind of bothersome.

example screenshot

Screen Shot 2021-07-23 at 11 18 50 AM

I'm not in favor of the drop shadow on the power button, however. I think it's a little visually confusing when you see it, since it's the only thing in the popup that would have that kind of lifted dimension.

@ablanathtanalba
Copy link
Contributor Author

What if the button class styling didn't change much, but we emphasized the power button icon a bit more?

Screen Shot 2021-07-23 at 11 30 13 AM

@ghostwords ghostwords force-pushed the make_disable_on_site_more_prominent branch from f34a677 to ea5cf91 Compare July 26, 2021 19:05
@ghostwords
Copy link
Member

Latest revision:

Screenshot from 2021-07-26 15-15-39

@ghostwords ghostwords force-pushed the make_disable_on_site_more_prominent branch from ea5cf91 to 4ea6261 Compare July 26, 2021 21:28
@ghostwords ghostwords merged commit 0976778 into master Jul 27, 2021
@ghostwords ghostwords deleted the make_disable_on_site_more_prominent branch July 27, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants