Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added auto generated Content ID header support #27

Closed
wants to merge 1 commit into from

Conversation

rdelpeso
Copy link

@rdelpeso rdelpeso commented Jun 5, 2022

  • Added support for auto generated Content ID headers per attachment

Usage:

await client.send({
  // Other items...
  html:
  'First image attachment <img src="cid:attachment_id_0"/> Second image attachment <img src="cid:attachment_id_1"/>',
});

In support of #25

@rdelpeso
Copy link
Author

rdelpeso commented Jun 5, 2022

Waiting for #26 before proceeding with this one.

@mathe42
Copy link
Member

mathe42 commented Jun 9, 2022

Looks good but I would add a option to the attachment object to set an ID as there might be use cases where you want to prepend your attachments allways with an extra attachment and then the IDs are not aligned.

So in the config add here

interface baseAttachment {
contentType: string;
filename: string;
}

id?: string | number

@mathe42
Copy link
Member

mathe42 commented Jun 9, 2022

I close this in favor of #28

@mathe42 mathe42 closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants