Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC_Query setOrder() と setLimit() の有効範囲を揃える #1116 #1134

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

SC_Query setOrder() と setLimit() の有効範囲を揃える #1116 #1134

wants to merge 4 commits into from

Conversation

seasoftjapan
Copy link
Contributor

fixed #1116

@seasoftjapan seasoftjapan added this to the 2.x milestone Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.09%. Comparing base (5ae14f6) to head (dabad1f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
data/class/api/operations/ItemSearch.php 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   49.94%   50.09%   +0.15%     
==========================================
  Files          82       82              
  Lines       10480    10494      +14     
==========================================
+ Hits         5234     5257      +23     
+ Misses       5246     5237       -9
Flag Coverage Δ
tests 50.09% <88.88%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seasoftjapan
SC_DB_DBFactory::addLimitOffset() 修正
e2dac78 
- MySQL で実行できない OFFSET 句の生成を回避。
- LIMIT 0 に対応する。
@seasoftjapan
SC_Query setOrder() と setLimit() の有効範囲を揃える #1116
5559b6a 
- getSql() LIMIT, OFFSET に対応。処理は SC_DB_DBFactory::addLimitOffset() に委ねる。
- getSql() 末尾で、句に関わる設定をリセットする。
- setLimitOffset()、setLimit()、setOffset() いずれも、MDB2 のラッパーではなく、getSql() に依存させる。
@seasoftjapan
SC_Query::getSql() の呼び出しを setLimit() を含めたメソッドチェーンとする。
0ac03af
@seasoftjapan
SC_Query setOrder() と setLimit() の有効範囲を揃える #1116
dabad1f 
- 共通部分 (SC_*) テスト追加
- 先日追加した SC_DB_DBFactory*Test はメンテが煩雑なので抽象化した。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.x
Development

Successfully merging this pull request may close these issues.

SC_Query setOrder() と setLimit() の有効範囲を揃える
1 participant
@seasoftjapan