Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symfony/polyfill-php73を削除したい #6279

Closed
ji-eunsoo opened this issue Sep 4, 2024 · 4 comments
Closed

symfony/polyfill-php73を削除したい #6279

ji-eunsoo opened this issue Sep 4, 2024 · 4 comments
Labels
security security
Milestone

Comments

@ji-eunsoo
Copy link
Contributor

概要(Overview)

#6277
でdependabotからPRがきているが、
symfony/polyfill-php73はもう利用しなく、php7.3との互換性を保つためのPRとなります。
php7.3と特に取り込みは不要となるため、削除したいです。

期待する内容(Expect) or 要望(Requirement)

"name": "symfony/polyfill-php73",

を削除

@dotani1111
Copy link
Contributor

使用されてない場合、削除してしまっても問題ないと思います。

@dotani1111 dotani1111 added this to the 4.3.x milestone Sep 9, 2024
@dotani1111 dotani1111 added the security security label Sep 9, 2024
@dotani1111
Copy link
Contributor

対象バージョン

  • polyfill-php73
  • polyfill-php72

手順

  1. composer require
  2. composer remove

PR対象ファイル

  • composer.json
  • compoer.lock

@dotani1111
Copy link
Contributor

dotani1111 commented Nov 6, 2024

composer require -> removeをしたら依存してるとの事です。

doctrine/orm 2.18.0 requires symfony/polyfill-php72 (^1.23)
symfony/polyfill-intl-idn v1.29.0 requires symfony/polyfill-php72 (^1.10)

ec-cube/ec-cube 4.3.x-dev requires symfony/polyfill-php73 (^1.31)
composer/composer 2.7.7 requires symfony/polyfill-php73 (^1.24)

@ji-eunsoo
Copy link
Contributor Author

@dotani1111
ありがとうございます。
削除できないので、CLOSEします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security security
Projects
None yet
Development

No branches or pull requests

2 participants