Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontawesomeの読み込み箇所にIntegrity属性を追加する #5946

Closed
chihiro-adachi opened this issue Feb 14, 2023 · 3 comments
Closed

fontawesomeの読み込み箇所にIntegrity属性を追加する #5946

chihiro-adachi opened this issue Feb 14, 2023 · 3 comments
Labels
good-first-issue Good for newcomers/簡単に修正できそうなもの improvement 機能改善
Milestone
4.2.2

Comments

@chihiro-adachi
Copy link
Contributor

概要(Overview)

fontawesomeの読み込み箇所にIntegrity属性を追加する

期待する内容(Expect) or 要望(Requirement)

以下の該当箇所に追加すること

<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.3.1/css/all.css">
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.3.1/css/v4-shims.css">
@chihiro-adachi chihiro-adachi added the improvement 機能改善 label Feb 14, 2023
@chihiro-adachi chihiro-adachi added this to the 4.2.x milestone Feb 14, 2023
@chihiro-adachi chihiro-adachi added the good-first-issue Good for newcomers/簡単に修正できそうなもの label Feb 14, 2023
@watarukashii
Copy link
Contributor

@chihiro-adachi
お世話になっております。下記issue と類似する内容かとおもいますが、合わせてご確認いただくことは可能でしょうか。
#5672

@chihiro-adachi
Copy link
Contributor Author

@watarukashii
#5672 は、Integrity属性とはまた別の内容になります。

コメント記載しておきました。
#5672 (comment)

@Atsu0601 Atsu0601 mentioned this issue Mar 25, 2023
Merged
15 tasks
@xuelian311 xuelian311 modified the milestones: 4.2.x, 4.2.2 May 9, 2023
@shinya
Copy link
Contributor

shinya commented Jun 9, 2023

こちらPRにてマージされたのでcloseしておきます。
（遅くなってすみません）

@shinya shinya closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers/簡単に修正できそうなもの improvement 機能改善
Projects
None yet
Milestone
4.2.2
Development

No branches or pull requests
4 participants
@watarukashii @chihiro-adachi @shinya @xuelian311