add sortgff and gff3trimfasta modules #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mberacochea
requested changes
Oct 16, 2024
| description: | | ||
| Groovy Map containing sample information | ||
| e.g. [ id:'test', single_end:false ] | ||
| - tab: |
There was a problem hiding this comment.
tab... gff seems more appropiate as a the name
There was a problem hiding this comment.
gff is used for output file
There was a problem hiding this comment.
sorterd_gff should be used for the gff then
| description: | | ||
| Groovy Map containing sample information | ||
| e.g. [ id:'test', single_end:false ] | ||
| - tab: |
There was a problem hiding this comment.
I would use gff instead of tab
There was a problem hiding this comment.
I'll leave is as tab, as I'm using gff for the output. Changed the descrition to be more specific
There was a problem hiding this comment.
it should be gff, tab doesn't really convey what the input is... I would change the output to tbe sorted_gff or similar
|
Please, run the pre-commits too. There area few linting issues |
mberacochea
requested changes
Oct 18, 2024
| container 'quay.io/biocontainers/gawk:4.1.3--0' | ||
|
|
||
| input: | ||
| tuple val(meta), path(tab) |
There was a problem hiding this comment.
Suggested change
| tuple val(meta), path(tab) | |
| tuple val(meta), path(gff) |
| tuple val(meta), path(tab) | ||
|
|
||
| output: | ||
| tuple val(meta), path("*._trimmed.gff"), optional: true, emit: gff |
There was a problem hiding this comment.
Suggested change
| tuple val(meta), path("*._trimmed.gff"), optional: true, emit: gff | |
| tuple val(meta), path("*._trimmed.gff"), optional: true, emit: trimmed_gff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.