Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icepack Consortium main #390fb5518326217c2501dbf5, Sept 30, 2023 #33

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Update Icepack Consortium main #390fb5518326217c2501dbf5, Sept 30, 2023 #33

merged 2 commits into from
Sep 30, 2023
+27 −15

Conversation

apcraig
Copy link
Collaborator

@apcraig apcraig commented Sep 30, 2023 •
edited by eclare108213
Loading

See CICE-Consortium#462

Define new parameter, tscale_pnd_drain, that sets the timescale (in days) for macroscopic drainage when using mushy thermodynamics. This parameterization is described in Turner and Hunke 2015 (eqn 47). It contributes to flushing along with gravity drainage, and therefore is not the timescale for flushing overall. tscale_pnd_drain = 1 / lambda_pond in icepack_therm_mushy.F90.

Note: tscale_pnd_drain is not (yet) a namelist parameter, but it is now available in parameters for drivers to set their own values. This is needed for E3SM.

Change the default value of dpscale (scaling factor for meltpond flushing with BL99 thermo) to 1.e-3 in the code. This is the value used in icepack_in and all of our tests.

Clarify definition of dpscale in the code and documentation - dpscale alters the timescale for drainage but is only a unitless scaling factor.

Fix enthalpy units in code comments.

eclare108213 and others added 2 commits September 30, 2023 12:24
@eclare108213
define parameter tscale_pnd_drain = 1 / lambda_pond; fix units and dp…
390fb55 
…scale documentation (CICE-Consortium#462)
@apcraig
Merge branch 'main' of https://github.com/cice-consortium/icepack int…
6a64845 
…o upd230930

Merge Consortium main #390fb5518326217c2501dbf5 to branch, Sept 30, 2023
@apcraig
Copy link
Collaborator Author

apcraig commented Sep 30, 2023

A full CICE test suite for the Consortium versions with these changes on cheyenne with intel passes all tests bit-for-bit.

@eclare108213 eclare108213 self-assigned this Sep 30, 2023
eclare108213
eclare108213 approved these changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were tested in Consortium suites. Will merge this now and then test it in Andrew's branch.

@eclare108213
Copy link
Collaborator

BFB in 3-month D cases:


    D3.nset05.emc.physics_cleanup2.update_icepack_8.eclare108213.anvil k001 - 
    D3.nset05.emc.physics_cleanup2.icepack-integration.eclare108213.anvil k001:

    iceAreaCell:  	BFB
    iceVolumeCell:  	BFB
    icePressure:  	BFB
    uVelocityGeo:  	BFB
    vVelocityGeo:  	BFB

    totalIceExtent:  	BFB
    totalIceVolume:  	BFB
    totalSnowVolume:  	BFB
    totalKineticEnergy:  	BFB
    averageAlbedo:  	BFB

@eclare108213 eclare108213 merged commit 96f2fc7 into E3SM-Project:cice-consortium/E3SM-icepack-initial-integration Sep 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees

@eclare108213 eclare108213

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213