Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of collection and stored procedure upon every instantiation? #23

Closed
deyanp opened this issue Apr 30, 2019 · 5 comments
Closed

Comments

@deyanp
Copy link

deyanp commented Apr 30, 2019

Is it possible to skip the collection/stored procedure check/creation? Sounds like at least 2 roundtrips which are not needed for subsequent calls, or am I missing something?

@Dzoukr
Copy link
Owner

Dzoukr commented Apr 30, 2019

Hi @deyanp,

currently it is not possible, but it happens only when you instantiate EventStore, which should happen only once per application. It is necessary to be sure that collection & stored procedure exist (in correct version).

@Dzoukr Dzoukr closed this as completed Apr 30, 2019
@deyanp
Copy link
Author

deyanp commented Apr 30, 2019

Hi @Dzoukr,

I intend to use this in Azure Function (serverless), and even though the function is kept around for some time, it will be also very often the case that a new instance of the function is created on regular basis. Any startup code or IO is going to have an impact ...

@Dzoukr
Copy link
Owner

Dzoukr commented Apr 30, 2019

Hm... I didn't think about that in that way (serverless)... I'll keep it here for tracking and try to involve it in next version.

@Dzoukr Dzoukr reopened this Apr 30, 2019
Dzoukr added a commit that referenced this issue May 17, 2019
@Dzoukr
Copy link
Owner

Dzoukr commented May 17, 2019

Fixed in v2.1.0

@Dzoukr Dzoukr closed this as completed May 17, 2019
@deyanp
Copy link
Author

deyanp commented May 17, 2019

Thanks a lot, @Dzoukr!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants