Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow validation in case multiple SRG exist in a single workflow #41

Open
eemrdog opened this issue Aug 11, 2023 · 2 comments · May be fixed by #66
Open

Workflow validation in case multiple SRG exist in a single workflow #41

eemrdog opened this issue Aug 11, 2023 · 2 comments · May be fixed by #66
Labels
Milestone

Comments

@eemrdog
Copy link

eemrdog commented Aug 11, 2023

"dta wf evaluate" as "dta srg evaluate" command would enable evaluating multiple SRGs in a single workflow. This will listen to a generated bizevent from the workflow.

Some possible cases:

  • The workflow may not have an SRG but this can check a workflow status as finished successfully or with a failure.
@drqc
Copy link
Collaborator

drqc commented Aug 15, 2023

a quick fix would be to have a parameter (NUMBER_OF_GUARDIANS_IN_WORKFLOW) in the CLI that the end user can configure with the number of guardians that the target workflows has. Then the CLI will wait for that number of anwers before getting the final result. If one of the results fails then its considered a fail evaluation

@eemrdog
Copy link
Author

eemrdog commented Aug 15, 2023

Instead of specifying an exact number of SRGs in a workflow, can we increase the interval of querying the bizevent?

For example 15 seconds, if there is multiple success results, then wait for another 15 seconds. If the number of success results are greater than the previous iteration, continue until the number of success results remains same. In case of fail result, it will exit immediately. Do you think it makes sense?

@drqc drqc added this to the 1.0.1 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants