Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize the annotation framework #1613

Closed
byron-hawkins opened this issue Mar 2, 2015 · 2 comments
Closed

Finalize the annotation framework #1613

byron-hawkins opened this issue Mar 2, 2015 · 2 comments
Assignees
@byron-hawkins
Labels
Type-Feature

Comments

@byron-hawkins
Copy link
Contributor

The annotation framework is currently available as a special build option. In the process of adding annotation tests to the suite (#1610) and considering special cases, minor corrections and adjustments may be necessary. After resolving these details and completing #1610, annotations will be enabled in the build by default.
@byron-hawkins byron-hawkins self-assigned this Mar 2, 2015
@byron-hawkins
Copy link
Contributor Author

An easy spot test for annotation overhead is to launch IE with the following page, which just exits IE:

<html>
<head>
<script language="JavaScript">
  document.write("closing in 1 second");
  // fool IE into thinking this is not a main window,
  // so closing needs no confirmation
  window.open('','_self','');
  window.close();
</script>
</head>
<body>
foo
</body>
</html>

It may be necessary to put the page on a webserver somewhere, or IE will not know what security domain it belongs in and will complain about running the script. The following DR options reduce noise in the test:

-disable_traces
-nop_initial_bblock
-fast_client_decode

@derekbruening derekbruening mentioned this issue Apr 1, 2015
Closed
@derekbruening
Copy link
Contributor

Annotations are enabled by default now for x86. For Mac we have the #1799 issue but that will be resolved once clang-9 is widespread. The main issue is the lack of ARM and AArch64 support: #1672.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byron-hawkins byron-hawkins

Labels
Type-Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@byron-hawkins @derekbruening