Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take over unknown threads for all injection paths #1304

Closed
derekbruening opened this issue Nov 28, 2014 · 2 comments
Closed

take over unknown threads for all injection paths #1304

derekbruening opened this issue Nov 28, 2014 · 2 comments

Comments

@derekbruening
Copy link
Contributor

From [email protected] on October 25, 2013 13:12:07

Xref DynamoRIO/drmemory#1355
Xref cygwin early thread problems
Xref issue #627 : early injected threads

Now that we have code to take over unknown threads on Windows, developed for attach ( issue #725 , r2032 ), we should use it whenever we start.

We just need to call dynamorio_take_over_threads() in auto_setup(), right?
The other threads do their own initialization, so tools should be fine with it.

This would also help Cygwin support.

dynamo_start() today calls dynamorio_take_over_threads() -- and it's used
by AppInit and early injection. So just switching drinject to use
earlier injection would pick this up automatically -- except DrMem (and
probably other WinAPI-using tools) can't handle earlier injection yet.

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=1304

@derekbruening
Copy link
Contributor Author

From [email protected] on October 25, 2013 11:47:33

Xref issue #1305 : we should really suspend these threads during DR init.
Today we'll do our init with them running native, and then take them over.

@derekbruening
Copy link
Contributor Author

From [email protected] on October 27, 2013 09:17:27

This issue was closed by revision r2339 .

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant