Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from NSIS to a WiX-based installer #1620

Closed
derekbruening opened this issue Nov 28, 2014 · 4 comments
Closed

Switch from NSIS to a WiX-based installer #1620

derekbruening opened this issue Nov 28, 2014 · 4 comments

Comments

@derekbruening
Copy link
Contributor

From [email protected] on September 08, 2014 15:00:58

Split from issue #1608 Quoting from there:

  1. Switch from NSIS to WiX. CPack 2.8.11+ supports WiX. WiX is MSI-based and so would have built-in uninstall support and also support for automatically replacing an existing installation. It should support everything we're currently doing with NSIS, and may make some things easier like writing the reg keys for the VS External Tool support.

Original issue: http://code.google.com/p/drmemory/issues/detail?id=1620

@blueelvis
Copy link

I think that adding the option to Explorer Integration would be suited very well on Windows. Imagine, no matter where the application's executable is located, just right click, Send To --> "Dr Memory" shortcut.

More Info - http://blogs.msdn.com/b/amb/archive/2012/02/19/how-to-add-notepad-shortcut-in-quot-send-to-quot-menu-on-windows-7.aspx

@derekbruening
Copy link
Contributor Author

blueelvis, thank you for the suggestion. Could you open a new, separate issue to track it? Let's keep this issue just on getting the features from our existing NSIS installer implemented in WiX.

@blueelvis
Copy link

@derekbruening - Issue created over here - #1683

@derekbruening
Copy link
Contributor Author

Just for the record:

There's something wrong with the "NOT Installed AND NOT REMOVE" trigger for add_vs_tool. If you make it Return="check" you can see that it tries to run it on uninstall! You end up with this error:

"There is a problem with this Windows Installer package. A program required for this install to complete could not be run."

Event log says: Product: Dr. Memory -- Error 1721. There is a problem with this Windows Installer package. A program required for this install to complete could not be run. Contact your support personnel or package vendor. Action: add_vs_tool, location: C:\Program Files (x86)\Dr. Memory\bin\vs_external_tool.exe, command: "C:\Program Files (x86)\Dr. Memory\bin\drmemory.exe"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants