Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamo Double Compare Inconsistency #9733

Closed
RyaPorter opened this issue May 23, 2019 · 3 comments
Closed

Dynamo Double Compare Inconsistency #9733

RyaPorter opened this issue May 23, 2019 · 3 comments
Labels
2.x Issues related to 2.x versions of Dynamo. bug tracked
Milestone

Comments

@RyaPorter
Copy link
Contributor

Dynamo version

2.3.0.5074 (master branch)

Operating system

Windows 10

What did you do?

Compared to doubles (4.701312264353, 4.70131302602723)

What did you expect to see?

The comparison 4.701312264353 < 4.70131302602723 to evaluate as True.

What did you see instead?

It evaluated as false:
Dynamo_CompareError

I'm pretty sure I'm not missing something obviously stupid. But Python confirms that something fundamental is wrong with, I'm guessing, DesignScript. (Again if I'm not missing something obviously stupid).

@RyaPorter
Copy link
Contributor Author

It seems very inconsistent. Returning different results depending on the amount of decimal points and significant figures:

Dynamo_CompareError_the_plot_thickens

Dynamo_CompareError_SigFigSmall

Dynamo_CompareError_the_plot_thickens_again

@Amoursol Amoursol added 2.x Issues related to 2.x versions of Dynamo. bug needs addressed labels Jun 28, 2019
@mjkkirschner
Copy link
Member

this is partially resolved. Equality still remains tolerant, discussing solutions at this point.

@mjkkirschner mjkkirschner added this to the 2.5.0 milestone Oct 6, 2019
@mjkkirschner
Copy link
Member

This should now be resolved I think as a new tolerant equals node has been added where tolerance is specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues related to 2.x versions of Dynamo. bug tracked
Projects
None yet
Development

No branches or pull requests

3 participants