Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node to code: Backslashes in strings do not get escaped #9117

Closed
andydandy74 opened this issue Sep 25, 2018 · 5 comments
Closed

Node to code: Backslashes in strings do not get escaped #9117

andydandy74 opened this issue Sep 25, 2018 · 5 comments
Labels
2.x Issues related to 2.x versions of Dynamo. engine Issues related to the engine driving Dynamo. priority Related to a release. tracked

Comments

@andydandy74
Copy link
Contributor

Dynamo version

2.0.1 stable

Operating system

Windows 10

What did you do?

Ran node to code on a string node that contained a string that ended with a backslash

What did you expect to see?

An error-free code block

What did you see instead?

Code block turned red, since backslash was not escaped upon conversion, producing a Invalid Associative_FunctionalStatement error.
grafik

@johnpierson johnpierson added priority Related to a release. 2.x Issues related to 2.x versions of Dynamo. engine Issues related to the engine driving Dynamo. labels Sep 26, 2018
@andydandy74 andydandy74 changed the title Node to code: Backslashes at end of strings do not get escaped Node to code: Backslashes in strings do not get escaped Sep 26, 2018
@andydandy74
Copy link
Contributor Author

I just realized that any backslash anywhere in a string node will trigger the same error (with the exception of standard escape sequences like \a, \b, \f, \n, \r, \t, \vand \0 - which don't trigger the error but will be converted to line breaks, tabs etc.).

@johnpierson
Copy link
Member

Tracked internally as QNTM-5742.

@andydandy74
Copy link
Contributor Author

andydandy74 commented Oct 31, 2018

FWIW, I solved this for myself with a view extension by modifying the StringInput values before calling NodeToCodeCommand:
https://github.com/andydandy74/Monito/blob/master/src/_Unfancify/UnfancifyViewModel.cs#L210

@johnpierson
Copy link
Member

@Amoursol
Copy link
Contributor

Now tracked internally at: DYN-1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues related to 2.x versions of Dynamo. engine Issues related to the engine driving Dynamo. priority Related to a release. tracked
Projects
Status: Done
Development

No branches or pull requests

4 participants