From f1452d6e7d8e2388406acce9c5016995cba3370a Mon Sep 17 00:00:00 2001 From: Jorgen Dahl Date: Fri, 9 Dec 2022 17:02:10 -0500 Subject: [PATCH] Don't throw if a package has dlls but no node libraries. (#13625) --- src/DynamoPackages/PackageLoader.cs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/DynamoPackages/PackageLoader.cs b/src/DynamoPackages/PackageLoader.cs index 66df796c3e2..33d6e02d699 100644 --- a/src/DynamoPackages/PackageLoader.cs +++ b/src/DynamoPackages/PackageLoader.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Generic; using System.IO; using System.Linq; @@ -692,15 +692,14 @@ private Version CheckAndGetPackageVersion(string version, string name, string di /// /// path to package location /// package object to check - private static void CheckPackageNodeLibraryCertificates(string packageDirectoryPath, Package discoveredPkg) + private void CheckPackageNodeLibraryCertificates(string packageDirectoryPath, Package discoveredPkg) { var dllfiles = new System.IO.DirectoryInfo(discoveredPkg.BinaryDirectory).EnumerateFiles("*.dll"); if (discoveredPkg.Header.node_libraries.Count() == 0 && dllfiles.Count() != 0) { - throw new LibraryLoadFailedException(packageDirectoryPath, - String.Format( - Resources.InvalidPackageNoNodeLibrariesDefinedInPackageJson, - discoveredPkg.Name, discoveredPkg.RootDirectory)); + Log(String.Format( + String.Format(Resources.InvalidPackageNoNodeLibrariesDefinedInPackageJson, + discoveredPkg.Name, discoveredPkg.RootDirectory))); } foreach (var nodeLibraryAssembly in discoveredPkg.Header.node_libraries)