Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capability to read inputs from netCDFs #389

Closed
Tracked by #418
dschlaep opened this issue Jan 10, 2024 · 0 comments · Fixed by #432
Closed
Tracked by #418

Capability to read inputs from netCDFs #389

dschlaep opened this issue Jan 10, 2024 · 0 comments · Fixed by #432
Assignees
@N1ckP3rsl3y
Labels
enhancement
Milestone
Release v8+

Comments

@dschlaep
Copy link
Member

  • Implement functionality to read inputs from netCDFs (if SWNETCDF)
  • Don’t read daily weather from text files for sw_template if all weather is provided by netCDFs
  • domainType vs. input types
    • a “sites” domain can read from input netCDFs that are “sites” or “xy”; if input netCDFs are of type “sites”, then they must match dimensions of domain
    • a “xy” domain requires “xy” input netCDFs
  • Input netCDFs may be larger, smaller, only partially overlap in space and time with the domain
  • We require that input netCDFs contain a set of CRS/XY-axis variables that matches up to such a set in the domain netCDF (fail if CRS not matching)
  • Maybe: Pre-calculate index positions and store in a “index” netCDF (or use a user-provided file)
  • As we loop over all simulation units in the domain, extract values for that suid/simulation run from each available input netCDFs
    • Retrieve index position from “index” netCDF
    • Read value(s)
    • Fail the run if no value (e.g., _FillValue)
    • Convert to SOILWAT2 units
    • Update local_sw
    • Run our checks on inputs (again) after values are updated from netCDFs
@dschlaep dschlaep added this to the Release v8.0.0 milestone Jan 10, 2024
@dschlaep dschlaep mentioned this issue Jan 10, 2024
Merged
14 tasks
@dschlaep dschlaep changed the title Capability to read (some) inputs from netCDFs Capability to read inputs from netCDFs Jun 5, 2024
@N1ckP3rsl3y N1ckP3rsl3y self-assigned this Jul 8, 2024
@dschlaep dschlaep mentioned this issue Jul 15, 2024
Draft
16 tasks
@N1ckP3rsl3y N1ckP3rsl3y mentioned this issue Aug 26, 2024
Merged
@N1ckP3rsl3y N1ckP3rsl3y linked a pull request Aug 26, 2024 that will close this issue
Input netCDFs #432
Merged
N1ckP3rsl3y added a commit that referenced this issue Jan 22, 2025
@N1ckP3rsl3y
Merge pull request #432 from DrylandEcology/feature_nc_input
e2940ed 
* SOILWAT2 currently has functionality to output simulated data through the netCDF (.nc) format (#390)
* Similarly, SOILWAT2 should allow the user to provide netCDF files with input data to use for the simulation which will replace the text (we use *.in) input file format
* Allow user to choose which input variables are provided by netCDFs while the others are input through text files
See #389

* Added smooth program ending when given a kill/terminate signal from the operating system (including the user interrupting the program)
* Provide a new framework to comprehensively test nc-based SOILWAT2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@N1ckP3rsl3y N1ckP3rsl3y

Labels
enhancement
Projects
None yet
Milestone
Release v8+
Development

Successfully merging a pull request may close this issue.

Input netCDFs DrylandEcology/SOILWAT2
2 participants
@dschlaep @N1ckP3rsl3y