Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: commlog messages are logged but they may have not been sent actually #348

Open
1 of 2 tasks
leon1995 opened this issue Feb 22, 2024 · 0 comments
Open
1 of 2 tasks
Labels
bug Something isn't working v2 Version 2 is affected

Comments

@leon1995
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

the comm log message is logged before it has been sent over the wire. this might lead to the situation where the message is logged but not actually sent.

Expected Behavior

only messages sent are logged

Minimal Reproducible Example

No response

Solution proposal

log messages after sending

Python Version

3.11

Operating system

windows

Sdc11073 Version

2.0.0

Link to sdc11073 Logs

No response

Further Information

No response

Participation

  • I am willing to submit a pull request to fix this bug.
@leon1995 leon1995 added bug Something isn't working v2 Version 2 is affected labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2 Version 2 is affected
Projects
None yet
Development

No branches or pull requests

1 participant