-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ihaskell-hvega with JupyterLab 2 #141
Comments
This may be relevant: https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.html#v2-0-0
|
|
Oh this looks suspicious. https://github.com/vega/vega/releases/tag/v5.0.0
That might be the culprit. |
The current Jupyter Lab and notebook interaction in notebookJupyter notebooks use the standard IHaskell The problem with this is that is pulls in old versions of the libraries - e.g. VegaEmbed 3.5.2 - and so won't work correctly with more-modern features. When I last tried to update these versions I ended up with JS problems. I forget now the details, but I think it involved the auto-loading done by EDITED TO ADD I believe this problem has been resolved with the labSince I have a The problem with this interface - that is https://github.com/DougBurke/hvega/blob/master/ihaskell-hvega/src/IHaskell/Display/Hvega.hs#L158 and also introduced in #12 - is that it relies on the IHaskell ** EDITED TO ADD MORE CONTENT** There is an update to allow a custom mimetype - see IHaskell/IHaskell#1089 - which has now been released in IHaskell, but it unfortunately does not help (it sends the data as a JSON string rather than a JSON object). We are working on this, but more eyes are always helpful: IHaskell/IHaskell#1173 There is also an added wrinkle (as noted in the JupyterLab discussion) that the supported version for VegaLite depends on whether you have v2 or an older version. I believe you can add support for newer (or older?) mimetypes, but that is getting beyond where I have time/energy to track things. |
@jamesdbrock - I just wanted to get the above written down for reference (and if anyone can provide help for these ;-) How do you install IHaskell? From stack/cabal, hackage, JupyterWIth, nix, ...? |
Thanks for writing this all down! My project https://github.com/jamesdbrock/ihaskell-notebook installs IHaskell and hvega from Github, so it would pick up the update with custom mimetype as soon as it was pushed. |
Sorry. Due to personal reasons my time is very limited at the momemt |
Hi, it looks like you spent some time on this. Thank you very much Doug, all the IHaskell users are very grateful to you. |
So, for referece, the It's still a mess if you use |
Hi @DougBurke ,ihaskell-hvega seems to have stopped working since I upgraded https://github.com/jamesdbrock/ihaskell-notebook to JuptyerLab 2. I can't find any errors at build time or runtime on backend or frontend, it just fails to render
vlShow
commands in the notebook.Before I start looking into this, can you tell me if ihaskell-hvega is known to work, or known to not work, with JupyterLab 2? Have you tried it?
The text was updated successfully, but these errors were encountered: