Skip to content
This repository has been archived by the owner on Dec 30, 2019. It is now read-only.

@ngrx/* update to v4, including required code adoptions. #5

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

DorianGrey
Copy link
Owner

@DorianGrey DorianGrey commented Jul 20, 2017

Took more effort than I previously expected, but seems to work now ...

However, some things are still left to be done:

@DorianGrey DorianGrey force-pushed the ngrx-4-update branch 6 times, most recently from aa539a1 to 78af1ce Compare July 24, 2017 13:10
@DorianGrey DorianGrey force-pushed the ngrx-4-update branch 4 times, most recently from e671734 to 46091d6 Compare August 3, 2017 07:11
@DorianGrey DorianGrey force-pushed the ngrx-4-update branch 2 times, most recently from bd8ad2d to 898b6c7 Compare August 9, 2017 06:30
@GiuseppePiscopo
Copy link

Hi there. Just chiming in: there seems to be updates and new directions on how to setup a custom router state serializer, to overcome issues with store dev tools. See ngrx/platform#188 and https://github.com/ngrx/platform/blob/master/docs/router-store/api.md#custom-router-state-serializer. HTH

@DorianGrey
Copy link
Owner Author

Using a custom serializer seems to be the way to go, yes. However, the corresponding commit was just merged yesterday (ngrx/platform@0fc1bcc) and is not yet published in a new version. I.e. although it is already listed in the docs (which are rendered from master), this feature cannot be used yet.
Be sure that I'll implement one once this gets released.

@DorianGrey DorianGrey force-pushed the ngrx-4-update branch 2 times, most recently from b3e5935 to a43c9b4 Compare August 11, 2017 07:43
@DorianGrey DorianGrey force-pushed the ngrx-4-update branch 5 times, most recently from 51a57ef to 851d366 Compare August 17, 2017 08:19
@DorianGrey
Copy link
Owner Author

Serializer added, ngrx-store-freeze and dev-tools working again ... and another issue raises:
ngrx/platform#286

Merge deferred until it's determined if the current workaround is fine, or if it has to be fixed in another way.

@DorianGrey DorianGrey merged commit 200cb00 into master Aug 18, 2017
@DorianGrey DorianGrey deleted the ngrx-4-update branch August 18, 2017 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants