-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distutils has been removed from Python 3.12 #73
Comments
@DoozyX Can you please enable PRs? It seems it should be very easy to fix. |
@levtoji PRs are always enabled, let me know if there is any issue |
Yeah sorry about the ping, I forgot about how to create PRs for not owned repos. I created a PR, maybe that is enough to fix the current problem. |
Hi, thanks for the quick action! It might also be a good idea to fix the full Python version backing the action to avoid similar problems in the future EDIT: that is, here: clang-format-lint-action/Dockerfile Line 1 in caa1792
Might also be worth it to switch away from running off the dockerfile and rather use a fixed image as suggested by @echoix here: #75 (comment) |
Given that #75 didn't work out and the current "fix" is to just pin the Python version to 3.11, this should probably be re-openend ^^" |
Hi, is there any further action for this issue? |
Can you still reproduce it and if so on what version? |
I think this is the wrong question. We would not expect to be able to reproduce it, because that is not the nature of the problem that motivated #78. The problem is that the "fix" was to pin to an older version of python. This is pretty clearly a temporary solution with a limited shelf life --- the clock is ticking. It's smart to get out ahead of the problem and find a permanent fix. I suggest reopening this issue and reviewing #78 for the next release. |
Starting with Python 3.12, Distutils has been removed https://peps.python.org/pep-0632/
It looks like the docker image python:3-alpine is based on 3.12, so this action no longer works.
Could you upgrade the Python script, or as a quick workaround use the python:3.11-alpine image?
Thanks
The text was updated successfully, but these errors were encountered: