This repository has been archived by the owner on Jul 14, 2020. It is now read-only.
Fix exception when an out-of-date descriptor is received #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where `None` was returned from `Instance.update_descriptor()` rather than a boolean. If a received instance descriptor is older than the current descriptor it was discarded and None was returned. Instead `False` should be returned as the boolean result it later compared in `descriptor_received()`. s
The Stem Tor control port library starts an event notifier thread and makes callbacks to the OnionBalance daemon with new events. If an unhandled exception occurs in an event callback the event notifier thread will crash. This will prevent OnionBalance getting new descriptor updates and eventual the onion service will go offline. This commit adds a `try: except` block around both event callback functions which should gracefully handle unexpected errors in the event notifier thread.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where
Nonewas returned fromInstance.update_descriptor()rather than a boolean. If a received instance descriptor is older than the current descriptor it was discarded and None was returned.Instead
Falseshould be returned as the boolean result it later compared indescriptor_received().Resolves exception in #62.