This repository has been archived by the owner on Jul 14, 2020. It is now read-only.
Fix bug where instance descriptors were thrown away after first match #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users would like to have multiple master services backed by the same set of instance addresses. This is equivalent to having multiple unique domains served by one set of load balancers. There was a bug where OnionBalance would discard a newly received instance descriptor after finding the first matching instance object. Other master services would not have their copy of that instance updated. This resulted in those other instances producing a "No descriptor received for instance" error. Thank you to Alec Muffett for reporting this issue. Resolves #47.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users would like to have multiple master services backed by the same set of instance addresses. This is equivalent to having multiple unique domains served by one set of load balancers.
There was a bug where OnionBalance would discard a newly received instance descriptor after finding the first matching instance object. Other master services would not have their copy of that instance updated. This resulted in those other instances producing a "No descriptor received for instance" error.
Thank you to Alec Muffett for reporting this issue.
Resolves #47.